-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BSP LCD display offset (BSP-611) #473
Conversation
561f552
to
69133d5
Compare
Hi @adamkaliszan, thank you for this PR. Please, could you help me understand these changes? What is the purpose? |
@adamkaliszan We would like to avoid having this configurable through menuconfig.
that performs the same thing you are trying to achieve. Would that solve your problem? |
69133d5
to
42250a1
Compare
My intention was to simplify launching new board. There is no need to make so deep changes and calling esp_lcd_panel_set_gap is enough. I have modified my PR and solved my problem by using esp_lcd_panel_set_gap. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adamkaliszan Thank you for these changes. Please, bump the version of BSP. LGTM
70b2a0e
to
fea7975
Compare
OK, great. Its done. |
fea7975
to
ce52cbb
Compare
Will be merged after #478 |
OK great. I/m going to Add BSP for lilygo TTGO board. |
@adamkaliszan We are not adding BSPs of third-party boards into this repository. I am sorry. We allow add only Espressif's and M5Stack boards. You can make it in own repository and add it into component registry: https://components.espressif.com/ |
95480df
to
f1311e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adamkaliszan Thank you. LGTM
ESP-BSP Pull Request checklist
Change description
Please describe your change here