Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I successfully used this driver with a SH1106 display by only changing the display offset. I'd like to make this change available to everyone. This is not a new BSP, nor I would create an entirely new component for this small change, so I'm submitting this pull request to know if you want to take if from here or should I continue my plan.
I propose:
esp_lcd_sh110x
sh110x_panel_t
to addoffset_param
two-byte param.ESP_LCD_IO_I2C_SH1107_CONFIG
to add the newoffset_param
set to0xd3 0x60
.ESP_LCD_IO_I2C_SH1106_CONFIG
withoffset_param
set to0xd3 0x00
.Please confirm my plans are OK and I'll make them and re-submit the pull request.
Thanks!
ESP-BSP Pull Request checklist
Change description
Please describe your change here