Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(zigbee): Enable the internal pull-up resistor for BUTTON_PIN #10491

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lboue
Copy link
Contributor

@lboue lboue commented Oct 21, 2024

Description of Change

Configure BUTTON_PIN/SWITCH_PIN as an input and enable the internal pull-up resistor.
I am facing a factory reset loop using a Waveshare ESP32-H2-DEV-KIT-N4 board witout enabling pull-up.

Tests scenarios

I tested this with :
Waveshare ESP32-H2-DEV-KIT-N4 board
ESP32-C6-WROOM-1 board

Related links

Please provide links to related issue, PRs etc.

Copy link
Contributor

github-actions bot commented Oct 21, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello lboue, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against d556fab

@lboue lboue changed the title Update Zigbee_Color_Dimmable_Light.ino Enable the internal pull-up resistor for BUTTON_PIN Oct 21, 2024
Copy link
Contributor

github-actions bot commented Oct 21, 2024

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32C6000.000.00000.000.00
ESP32H2000.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32C6ESP32H2
ExampleFLASHRAMFLASHRAM
Zigbee/examples/Zigbee_Color_Dimmable_Light0000
Zigbee/examples/Zigbee_Color_Dimmer_Switch0000
Zigbee/examples/Zigbee_On_Off_Light0000
Zigbee/examples/Zigbee_Temperature_Sensor0000
Zigbee/examples/Zigbee_Thermostat0000

Copy link
Contributor

github-actions bot commented Oct 21, 2024

Test Results

 56 files   56 suites   4m 9s ⏱️
 21 tests  21 ✅ 0 💤 0 ❌
134 runs  134 ✅ 0 💤 0 ❌

Results for commit d556fab.

♻️ This comment has been updated with latest results.

Enable the internal pull-up resistor for BUTTON_PIN
@lboue lboue changed the title Enable the internal pull-up resistor for BUTTON_PIN fix(zigbee): Enable the internal pull-up resistor for BUTTON_PIN Oct 21, 2024
@lboue lboue marked this pull request as ready for review October 21, 2024 15:26
@me-no-dev
Copy link
Member

@P-R-O-C-H-Y PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants