fix(esp_tls): prevent freeing global CA store after each request (GIT8266O-614) #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
AdityaHPatwardhan
approved these changes
Jan 25, 2021
Co-authored-by: AdityaHPatwardhan <[email protected]>
SiarheiVolkau
added a commit
to SiarheiVolkau/esp-idf
that referenced
this pull request
Jan 25, 2021
Identical PR for ESP8266 espressif/ESP8266_RTOS_SDK#1037 Not tested on ESP32.
|
Sorry for the earlier fix which was wrong @SiarheiVolkau, The commit you previously added was correct but did not satisfy esp-idf style guidelines. So I have suggested this change. I had mistakenly added only half part in the previous suggestion |
Co-authored-by: AdityaHPatwardhan <[email protected]>
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.