Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mi/Xiaomi Desklamps: fix ignore_efuse_custom_mac, update component usage #997

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mjbogusz
Copy link

Brief description of the changes

As per esphome/issues#6333, since esphome 2024.10 the ignore_efuse_mac_crc flag is not enough - this PR adds the missing ignore_efuse_custom_mac to the affected devices.

I also took the liberty to update the component usage in provided example configs to their up-to-date recommended structures (e.g. ota as a list); Additionally I've re-enabled web_server and captive_portal, previously unavailable in esp-idf.

I've verified the updated config on a 1S model; Pro is virtually identical, at least pinout-wise.

If preferred, I can split out the changes into a minimal efuse flag fix and a separate commit/PR for the rest.

Type of changes

  • New device
  • Update existing device
  • Removing a device
  • General cleanup
  • Other

Checklist:

  • There are no passwords or secrets references in any examples.
    The only exceptions are !secret wifi_ssid and !secret wifi_password.
  • The wifi or ethernet block has no static / manual ip address specified.
  • The first configuration provided should be hardware definitions only.
    A more involved example can be provided in a separate configuration block.

Copy link

netlify bot commented Jan 21, 2025

Deploy Preview for esphome-devices ready!

Name Link
🔨 Latest commit 77c9615
🔍 Latest deploy log https://app.netlify.com/sites/esphome-devices/deploys/678fed1e8649060008fa2e73
😎 Deploy Preview https://deploy-preview-997--esphome-devices.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 97 (🟢 up 4 from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 89 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant