git add . add package common-phrases #151
Conversation
| ## Installation | ||
|
|
||
| ```bash | ||
| espanso install commonPhrases |
There was a problem hiding this comment.
The Hub automatically shows the installation instructions for all the packages, so it isn't necessary to include them here.
If you want to, however, the line will be espanso install common-phrases to match the package name, and espanso restart isn't needed.
There was a problem hiding this comment.
ive fixed that 👌 thank you for your comment
ps. ive used one of the packages (quick-translate) and had issue with the rtl languages so i tired multiple solutions until one worked decent still some little issues, so i am wondering should i just add my changes or should i get in contact with someone?
There was a problem hiding this comment.
Thank you for doing that. The package had passed its automated checks so I'm about to merge it.
As far as quick-translate is concerned, ideally you would fork @p0ly60n's repo https://github.com/p0ly60n/quick-translate or https://github.com/p0ly60n/hub-quick-translate and submit a PR with your improvements, for them to PR to espanso/hub, attributing you accordingly. Although @p0ly60n isn't very active on GitHub, the package is relatively recent, and he/she did communicate via the Espanso Discord server. If you get no response after a month or so, by all means fork the Hub and PR directly - this is what I have had to do with some of the older PRs which needed fixing. Let me know if you need any help.
There was a problem hiding this comment.
Hello,
just got the notification. How can I help?
|
All done: https://hub.espanso.org/common-phrases. |
No description provided.