german-words

[Fatih5252]

New Package with german words

[Fatih5252]

Its not fully done so updates will come soon

[Fatih5252]

here are more changes

[smeech]

A simple package of some 250 trigger/replace pairs. No script, shell, or potentially malicious code.

The replacement capitalisation varies, and there are some duplicates which are or aren't capitalised. I did wonder if Word Triggers and some instances of Case Propagation might add something to the package, but most of the words are not likely to occur at the beginning of sentences, I guess, and the latter is difficult to implement using a prefix character.

Would you have a look at the Hub and add a few more tags to help users find your package, please? languages is an obvious, popular example.

As you have suggested this is still a work in progress I've marked it as Draft, so we don't merge it prematurely, but let me know when you think it's ready.

[Fatih5252]

Im on my way!

[Fatih5252]

sorry, i forgot to change some words at the first commit

[Fatih5252]

now solved everything, for now its okay but i will put more words.

[smeech]

I've enjoyed watching this evolve!

You're welcome to ignore my comments, and we can sort things out at the end, but there are a few things you might like to consider as we go along.

Best wishes!

[Fatih5252]

there you have it! i did everything, fixed the "potato" trigger at line 488, did add the propagate_case: true feature and added more tags!

[smeech]

We're nearly there.

I downloaded your package to test, and find that, because :o, :a, and :u trigger first, all other words beginning with these letters won't ever be triggered. Try: :only, :on, :ocean, :old, :open, and similarly :apple etc. and :ugly etc.. There are various possible remedies, such as a double-prefix ::o, or a prefix/suffix, :a:, or a different prefix character, or add the word: true key/value to the other triggers in the file, etc..

Would you also kindly expand the README.md file a little, please? If you look at some of the examples in the Hub (and I'm sorry they don't all work!) e.g. https://hub.espanso.org/greetings-german. I see these as the shopfront of the package for anyone browsing. It doesn't need to be a lot more to make it interesting.

[Fatih5252]

sorry for the "ä, ü, ö" mistake. i forgot about that.

[smeech]

sorry for the "ä, ü, ö" mistake. i forgot about that.

Just spotted :s→ß, I'm afraid - same problem!

BTW, potato doesn't have a prefix : - only spotted it when I sorted the file (it would be neat to publish it that way, as it makes it easier to find specific triggers).

[smeech]

"baggage" (spelling)?

[Fatih5252]

sorry again! there we go now

[smeech]

Thank you.

When you're happy with it, let me know, and I will go ahead and merge (after I've sorted it alphabetically! 😆 ).
If you're still working on it and want to wait, there's no rush. I note you've been diligently updating the version, so you can easily submit an update once it's in the Hub.

[Fatih5252]

ok thats it! im guessing that this is all the basic words i could find and think!

[smeech]

Merged!