Make the libudev dependency optional #709
Merged
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivmarkov
force-pushed
the
optional-libudev
branch
from
01668eb to
b4818b2
Compare
|
@SergioGasquez I think somebody needs to run I can do it as part of this PR, but that might mean the 3-line change I did might get lost in the noise? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject says it all.
The main driver for this is to be able to cross-compile
espflashfor other Linux targets (e.g. Raspberry Pi) with either:or
Neither of these can do it when the dependency to
libudevis present, and both do succeed when the dependency tolibudevis not there.I'm yet to test this on a RPI (real soon), but on a regular Ubuntu 22.04, disabling the
libudevdependency actually does not lead to a visible loss in functionality. At least not whenespflashis driven programmatically via its API as I did./dev/ttyUSB0is still detected as the serial port where the esp32(s3) device is answering.