Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(kernel): fix typos #8927

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

hauleth
Copy link
Contributor

@hauleth hauleth commented Oct 10, 2024

Cleanup typographic errors in kernel code.

Not all errors are yet cleaned up, as it requires some additional
considerations.

Cleanup typographic errors in `kernel` code.

Not all errors are yet cleaned up, as it requires some additional
considerations.
Copy link
Contributor

github-actions bot commented Oct 10, 2024

CT Test Results

    2 files     69 suites   1h 5m 3s ⏱️
1 518 tests 1 280 ✅ 223 💤 15 ❌
1 732 runs  1 464 ✅ 253 💤 15 ❌

For more details on these failures, see this check.

Results for commit 271dd70.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

Copy link
Contributor

@jhogberg jhogberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I'm not sure that we should change misspelled atoms exposed in public interfaces -- a test case failed because of this and it's possible (albeit very unlikely) that some user might've expected the same. Can we split this into one commit for comments and documentation, and another for code?

As an aside, please change the commit format to kernel: Fix typos. We don't use chore(...) or feat(...). :-)

@@ -310,7 +310,7 @@ handler_loop(Sock, {select_info, recv, SelectHandle}) ->
end;

%% This is the (asyncronous) behaviour on platforms that support 'completion',
%% currently only Windows.
%% currently onla Windows.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
%% currently onla Windows.
%% currently only Windows.

@@ -476,7 +476,7 @@ <H3> THE FUTURE</H3>
will be Real Programmers willing to jump in and Solve The Problem,
saving the documentation for later. Long live FORTRAN! <P>

<H3>ACKNOWLEGEMENT</H3>
<H3>ACKNOWLEDGEMENT</H3>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a pre-existing document included as test data, let's skip this one.

@jhogberg jhogberg self-assigned this Oct 14, 2024
@jhogberg jhogberg added the team:VM Assigned to OTP team VM label Oct 14, 2024
@hauleth
Copy link
Contributor Author

hauleth commented Oct 14, 2024

Yeah, I forgot about naming scheme and I do not think that it is in CONTRIBUTING.md. I will clean this up and make it pass (as I have incorrectly fixed some of the variables' names).

@garazdawi
Copy link
Contributor

I do not think that it is in CONTRIBUTING.md

There is a link in CONTRIBUTING.md to this wiki page about how to write commit messages: https://github.com/erlang/otp/wiki/Writing-good-commit-messages#do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:VM Assigned to OTP team VM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants