Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add json format functions for key-value lists #8889

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add json format functions for key-value lists #8889

wants to merge 1 commit into from
+241 −7

Conversation

isvilen
Copy link
Contributor

@isvilen isvilen commented Oct 2, 2024

Support formatting key-value lists while preserve their ordering.
Closes #8882

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024 •
edited
Loading

CT Test Results

    2 files     96 suites   1h 7m 45s ⏱️
2 163 tests 2 115 ✅ 48 💤 0 ❌
2 522 runs  2 472 ✅ 50 💤 0 ❌

Results for commit dd84bb5.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

vkatsuba
vkatsuba reviewed Oct 2, 2024
View reviewed changes
lib/stdlib/src/json.erl Outdated Show resolved Hide resolved
lib/stdlib/src/json.erl Show resolved Hide resolved
lib/stdlib/src/json.erl Show resolved Hide resolved
lib/stdlib/src/json.erl Outdated Show resolved Hide resolved
@IngelaAndin IngelaAndin added the team:PS Assigned to OTP team PS label Oct 4, 2024
dgud
dgud requested changes Oct 8, 2024
View reviewed changes
lib/stdlib/src/json.erl Outdated Show resolved Hide resolved
lib/stdlib/test/json_SUITE.erl Show resolved Hide resolved
@isvilen isvilen requested a review from dgud October 10, 2024 06:04
@dgud dgud added the testing currently being tested, tag is used by OTP internal CI label Oct 23, 2024
@dgud
Copy link
Contributor

dgud commented Oct 25, 2024

Can you squash the commits and force-push..

@isvilen @vkatsuba @Maria-12648430
Add json format functions for key-value lists
dd84bb5 
Support formating key-value lists while preserve their ordering.

Co-authored-by: Viacheslav Katsuba <[email protected]>
Co-authored-by: Maria Scott <[email protected]>
@isvilen
Copy link
Contributor Author

isvilen commented Oct 25, 2024

Can you squash the commits and force-push..

Done, should I also rebase it onto main ?

@dgud dgud removed the testing currently being tested, tag is used by OTP internal CI label Oct 25, 2024
@dgud
Copy link
Contributor

dgud commented Oct 25, 2024

I think you are already based of maint branch.

I could merge it without getting any changes from master, what I saw at least, but could have missed something.
Checked and it looks ok to me, before the squash at least and still good after squash :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maria-12648430 Maria-12648430 Maria-12648430 left review comments

@dgud dgud dgud approved these changes

@vkatsuba vkatsuba vkatsuba approved these changes

Assignees

@dgud dgud

Labels
team:PS Assigned to OTP team PS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

json module format functions for key-value lists
5 participants
@isvilen @dgud @vkatsuba @Maria-12648430 @IngelaAndin