Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use process.hrtime instead of Date #103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use process.hrtime instead of Date #103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 20 additions & 20 deletions test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@ var sleep = require('./');
var assert = require('assert');
var child_process = require('child_process');

function assertApproxEqual(val1, val2) {
function assertApproxEqual(gotInHr, expectedInMs) {
// We require accuracy to the nearest N millisecond.
// Windows Sleep is not super accurate (depends on scheduling policy) so use a high value.
var epsilon = 100;
var diff = val1 - val2;
var diff = (gotInHr[0] * 1000 + Math.round(gotInHr[1] / 1000000)) - expectedInMs;
if (diff > epsilon) {
assert.fail('wait was too long: ' + diff + ' > ' + epsilon);
} else if (diff < -epsilon) {
Expand All @@ -18,18 +18,18 @@ function assertApproxEqual(val1, val2) {
describe('sleep', function () {
it('works for normal input', function () {
var sleepTime = 1;
var start = new Date();
var start = process.hrtime();
sleep.sleep(sleepTime);
var end = new Date();
assertApproxEqual(end - start, sleepTime * 1000);
var end = process.hrtime(start);
assertApproxEqual(end, sleepTime * 1000);
});

it('works for zero', function () {
var sleepTime = 0;
var start = new Date();
var start = process.hrtime();
sleep.sleep(sleepTime);
var end = new Date();
assertApproxEqual(end - start, sleepTime * 1000);
var end = process.hrtime(start);
assertApproxEqual(end, sleepTime * 1000);
});

it('does not allow negative numbers', function () {
Expand All @@ -41,29 +41,29 @@ describe('sleep', function () {
it('works with child_process', function () {
var sleepTime = 1;
child_process.exec('echo', function (err, stdout, stderr) { });
var start = new Date();
var start = process.hrtime();
sleep.sleep(sleepTime);
var end = new Date();
assertApproxEqual(end - start, sleepTime * 1000);
var end = process.hrtime(start);
assertApproxEqual(end, sleepTime * 1000);
});
});

describe('usleep', function () {
it('works for values smaller than a second', function () {
var sleepTime = 250;
var start = new Date();
var start = process.hrtime();
sleep.usleep(sleepTime);
var end = new Date();
assertApproxEqual(end - start, sleepTime / 1000);
var end = process.hrtime(start);
assertApproxEqual(end, sleepTime / 1000);
});

it('works for values larger than a second', function () {
this.timeout(4000); // necessary for mocha to not complain
var sleepTime = 3000000;
var start = new Date();
var start = process.hrtime();
sleep.usleep(sleepTime);
var end = new Date();
assertApproxEqual(end - start, sleepTime / 1000);
var end = process.hrtime(start);
assertApproxEqual(end, sleepTime / 1000);
});

it('does not allow negative numbers', function () {
Expand All @@ -76,10 +76,10 @@ describe('usleep', function () {
describe('msleep', function () {
it('works for normal input', function() {
var sleepTime = 1;
var start = new Date();
var start = process.hrtime();
sleep.msleep(sleepTime);
var end = new Date();
assertApproxEqual(end - start, sleepTime);
var end = process.hrtime(start);
assertApproxEqual(end, sleepTime);
});

it('does not allow negative numbers', function () {
Expand Down