fix: improve net_listening implementation #13387
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mh0lt
approved these changes
Jan 14, 2025
|
@mh0lt if everything is alright, can you merge it please? |
| func (api *NetAPIImpl) Listening(_ context.Context) (bool, error) { | ||
| func (api *NetAPIImpl) Listening(ctx context.Context) (bool, error) { | ||
| if api.ethBackend == nil { | ||
| // We're running in --datadir mode or otherwise cannot get the backend |
There was a problem hiding this comment.
We have RemoteBackend in this case: which has GRPC methods
There was a problem hiding this comment.
Here:
erigon/cmd/rpcdaemon/cli/config.go
Line 355 in b2f772b
|
@AskAlexSharov made some changs, what do you think abt them? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace hardcoded value with actual network state check.
The method now properly reflects network connectivity status by checking if the node can communicate with the network.