downloader: small refactoring #13338
Conversation
dvovk
requested review from
mh0lt and
AskAlexSharov
and removed request for
mh0lt
erigon-lib/downloader/downloader.go
Outdated
| @@ -2968,3 +2904,71 @@ func (d *Downloader) CompletedTorrents() map[string]completedTorrentInfo { | |||
|
|
|||
| return d.completedTorrents | |||
| } | |||
|
|
|||
| func (d *Downloader) collectWebDownloadClientStats(downloading *map[string]*downloadInfo, stats *AggStats, zeroProgress *[]string, webTransfers *int32) { | |||
There was a problem hiding this comment.
webTransfers, zeroProgress could be a return value instead of passed by ptr.
Of course zero progress list should be appended to existing one but would be cleaner
erigon-lib/downloader/downloader.go
Outdated
| tLen := transfer.Size | ||
| transferName := transfer.Name | ||
|
|
||
| delete(*downloading, transferName) |
There was a problem hiding this comment.
i know before we also had a deletion here but SHOULD we really delete file name here? webStats.Transferring supposes transfer is not over yet so why need to delete it from downloading map?
There was a problem hiding this comment.
I agree that it is looks not logical but the issue is that we don't use web download client(WDL) and this code is just sitting here without usage so that is why I decided to move it into the separate function. Maybe it even worth to delete it completely as I will not spend time to setup, test, etc... for WDL and I don't think that anyone else will do it in near future.
erigon-lib/downloader/downloader.go
Outdated
| } | ||
| } | ||
|
|
||
| *webTransfers += int32(len(*downloading)) |
There was a problem hiding this comment.
so should we add size of downloading list after we counted each transfer and removed filename from downloading list?
|
another approach could be AggStat object delta which should be added to existing aggStat. So different modules return new AggStat with non zero fields only where needed and then we Add those stats to main statistics object, which also easier to maintain and read. |
Move code which calculates rates for web downloader client to separate function.