Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update remotedialer #6478

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CeerDecy
Copy link
Member

@CeerDecy CeerDecy commented Jan 7, 2025

What this PR does / why we need it:

update remotedialer for cluster manager

Which issue(s) this PR fixes:

Specified Reviewers:

/assign @iutx @sfwn

ChangeLog

Language Changelog
🇺🇸 English update remotedialer for cluster manager
🇨🇳 中文 更新cluster-manager中的remotedialer

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@erda-bot
Copy link
Member

erda-bot commented Jan 7, 2025

Add assignees failed, err: Post "https://api.github.com/repos/erda-project/erda/pulls/6478/requested_reviewers": proxyconnect tcp: dial tcp 8.218.184.45:34894: i/o timeout

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 15.12%. Comparing base (4dacc50) to head (051cd35).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ols/cluster-manager/dialer/server/tunnel-server.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6478      +/-   ##
==========================================
- Coverage   15.12%   15.12%   -0.01%     
==========================================
  Files        3675     3675              
  Lines      377020   377020              
==========================================
- Hits        57040    57028      -12     
- Misses     314530   314545      +15     
+ Partials     5450     5447       -3     
Flag Coverage Δ
by-github-actions 15.12% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ols/cluster-manager/dialer/server/tunnel-server.go 38.03% <0.00%> (ø)

... and 5 files with indirect coverage changes

Copy link
Member

@iutx iutx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants