Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: waitgroup in gorouting not done in time when list runtimes has error #6473

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

polish: use StatusReady and StatusHealthy, convert to DiceYaml object…

73a961a
Select commit
Loading
Failed to load commit list.
Open

fix: waitgroup in gorouting not done in time when list runtimes has error #6473

polish: use StatusReady and StatusHealthy, convert to DiceYaml object…
73a961a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 24, 2025 in 1s

15.11% (target 10.00%)

View this Pull Request on Codecov

15.11% (target 10.00%)

Details

Codecov Report

Attention: Patch coverage is 0% with 37 lines in your changes missing coverage. Please review.

Project coverage is 15.11%. Comparing base (9aaa584) to head (73a961a).
Report is 16 commits behind head on master.

Files with missing lines Patch % Lines
...nal/tools/orchestrator/services/runtime/runtime.go 0.00% 37 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6473      +/-   ##
==========================================
- Coverage   15.14%   15.11%   -0.03%     
==========================================
  Files        3674     3675       +1     
  Lines      376844   377006     +162     
==========================================
- Hits        57076    56990      -86     
- Misses     314307   314568     +261     
+ Partials     5461     5448      -13     
Files with missing lines Coverage Δ
...nal/tools/orchestrator/services/runtime/runtime.go 13.05% <0.00%> (-0.07%) ⬇️

... and 23 files with indirect coverage changes