Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add status as a condition for searching registercenter #6455

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

CeerDecy
Copy link
Member

What this PR does / why we need it:

add status as a condition for searching registercenter

Which issue(s) this PR fixes:

  • Fixes #your-issue_number
  • [Erda Cloud Issue Link](paste your link here)

Specified Reviewers:

/assign @iutx

ChangeLog

Language Changelog
🇺🇸 English add status as a condition for searching registercenter
🇨🇳 中文 添加status作为查询注册中心的条件

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@erda-bot erda-bot requested a review from iutx October 22, 2024 02:37
iutx
iutx previously approved these changes Oct 22, 2024
Copy link
Member

@iutx iutx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @sfwn

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 15.14%. Comparing base (b46e4bf) to head (333a276).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...rnal/tools/orchestrator/dbclient/addon_instance.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6455      +/-   ##
==========================================
- Coverage   15.61%   15.14%   -0.47%     
==========================================
  Files        3674     3674              
  Lines      311277   376844   +65567     
==========================================
+ Hits        48604    57071    +8467     
- Misses     257248   314311   +57063     
- Partials     5425     5462      +37     
Flag Coverage Δ
by-github-actions 15.14% <0.00%> (-0.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...duler/executor/plugins/k8s/instanceinfosync/pod.go 0.00% <ø> (ø)
...rnal/tools/orchestrator/dbclient/addon_instance.go 0.00% <0.00%> (ø)

... and 3291 files with indirect coverage changes

Signed-off-by: CeerDecy <[email protected]>
@sfwn
Copy link
Member

sfwn commented Oct 23, 2024

/approve

@sfwn sfwn merged commit 9aaa584 into erda-project:master Oct 23, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants