-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pipeline): inject project/org default namespace for ci/cd pipeline #6443
Conversation
@@ -95,6 +95,11 @@ func (e *Endpoints) pipelineCreate(ctx context.Context, r *http.Request, vars ma | |||
if err != nil { | |||
return errorresp.ErrResp(err) | |||
} | |||
|
|||
// also add project/org default config namespace | |||
reqPipeline.ConfigManageNamespaces = append(reqPipeline.ConfigManageNamespaces, makeProjectDefaultLevelCmsNs(app.ProjectID)...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
project namespace should be placed after org namespace, for priority reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
98e8a30
to
a113a8e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6443 +/- ##
=======================================
Coverage 15.62% 15.62%
=======================================
Files 3674 3674
Lines 311601 311609 +8
=======================================
+ Hits 48675 48686 +11
+ Misses 257466 257462 -4
- Partials 5460 5461 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/approve |
What this PR does / why we need it:
inject project/org default namespace for ci/cd pipeline
Specified Reviewers:
/assign @sfwn
ChangeLog
Need cherry-pick to release versions?
Add comment like
/cherry-pick release/1.0
when this PR is merged.