-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(collector): auth validator is nil #6442
Conversation
Signed-off-by: Ash <[email protected]>
Validator authentication.Validator `autowired:"erda.oap.collector.authentication.Validator"` if p.Cfg.Auth.Skip {
p.Validator = skipValidator{}
} |
Signed-off-by: Ash <[email protected]>
/hold |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6442 +/- ##
==========================================
- Coverage 15.62% 15.61% -0.01%
==========================================
Files 3674 3674
Lines 311576 311582 +6
==========================================
- Hits 48675 48668 -7
- Misses 257450 257460 +10
- Partials 5451 5454 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
….Validator Signed-off-by: Ash <[email protected]>
Signed-off-by: Ash <[email protected]>
related pr: 6420 |
/approve |
What this PR does / why we need it:
fix auth validator is nil
Which issue(s) this PR fixes:
Specified Reviewers:
/assign @chengjoey @sfwn
ChangeLog
Need cherry-pick to release versions?
Add comment like
/cherry-pick release/1.0
when this PR is merged.