Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(monitor): cpu usage in resource-container-monitor #6415

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

chengjoey
Copy link
Contributor

What this PR does / why we need it:

fix cpu usage in resource-container-monitor

Which issue(s) this PR fixes:

Specified Reviewers:

/assign @sfwn

ChangeLog

Language Changelog
🇺🇸 English Fix the bug that cpu usage in resource-container-monitor
🇨🇳 中文 修复了微服务容器监控cpu使用率错误的问题

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@erda-bot erda-bot added the bugfix label Aug 2, 2024
@erda-bot erda-bot requested a review from sfwn August 2, 2024 08:27
@sfwn
Copy link
Member

sfwn commented Aug 2, 2024

/approve

@sfwn
Copy link
Member

sfwn commented Aug 2, 2024

/approve

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.60%. Comparing base (376e630) to head (3a81f75).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6415      +/-   ##
==========================================
- Coverage   15.60%   15.60%   -0.01%     
==========================================
  Files        3677     3677              
  Lines      311998   312000       +2     
==========================================
- Hits        48677    48672       -5     
- Misses     257864   257869       +5     
- Partials     5457     5459       +2     
Flag Coverage Δ
by-github-actions 15.60% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../resources-container-monitor/container/provider.go 84.83% <100.00%> (ø)

... and 7 files with indirect coverage changes

@erda-bot erda-bot merged commit f4b3853 into erda-project:master Aug 2, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants