Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove steve cache ttl #6412

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Conversation

CeerDecy
Copy link
Member

@CeerDecy CeerDecy commented Aug 1, 2024

What this PR does / why we need it:

remove steve cache ttl

Which issue(s) this PR fixes:

Specified Reviewers:

/assign @iutx

ChangeLog

Language Changelog
🇺🇸 English remove steve cache ttl
🇨🇳 中文 取消Steve cache的过期时间

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@erda-bot erda-bot added the bugfix label Aug 1, 2024
@erda-bot erda-bot requested a review from iutx August 1, 2024 03:28
@CeerDecy CeerDecy marked this pull request as ready for review August 1, 2024 03:28
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.60%. Comparing base (5a424b2) to head (029e16c).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6412      +/-   ##
==========================================
- Coverage   15.60%   15.60%   -0.01%     
==========================================
  Files        3677     3677              
  Lines      312018   312018              
==========================================
- Hits        48703    48690      -13     
- Misses     257860   257869       +9     
- Partials     5455     5459       +4     
Flag Coverage Δ
by-github-actions 15.60% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

Copy link
Member

@iutx iutx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @sfwn

@sfwn
Copy link
Member

sfwn commented Aug 2, 2024

Maybe you can simply accomplish this by set TTL to -1, or sth like this. @CeerDecy

@CeerDecy
Copy link
Member Author

CeerDecy commented Aug 5, 2024

Maybe you can simply accomplish this by set TTL to -1, or sth like this. @CeerDecy

can't set to never expire by setting Expiration=-1, and the cache code doesn't do anything special with -1. @sfwn
image
image

@sfwn
Copy link
Member

sfwn commented Aug 5, 2024

/approve

@erda-bot erda-bot merged commit 8543dc0 into erda-project:master Aug 5, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants