-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove steve cache ttl #6412
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6412 +/- ##
==========================================
- Coverage 15.60% 15.60% -0.01%
==========================================
Files 3677 3677
Lines 312018 312018
==========================================
- Hits 48703 48690 -13
- Misses 257860 257869 +9
- Partials 5455 5459 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @sfwn
Maybe you can simply accomplish this by set TTL to -1, or sth like this. @CeerDecy |
/approve |
What this PR does / why we need it:
remove steve cache ttl
Which issue(s) this PR fixes:
Specified Reviewers:
/assign @iutx
ChangeLog
Need cherry-pick to release versions?
Add comment like
/cherry-pick release/1.0
when this PR is merged.