Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set docker syntax using erda registry #6392

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

chengjoey
Copy link
Contributor

What this PR does / why we need it:

set docker syntax using erda registry

Which issue(s) this PR fixes:

Specified Reviewers:

/assign @sfwn

ChangeLog

Language Changelog
🇺🇸 English set docker syntax using erda registry
🇨🇳 中文 更改默认dockerfile的syntax

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@erda-bot erda-bot requested a review from sfwn July 9, 2024 06:18
Copy link
Member

@iutx iutx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -1,4 +1,4 @@
# syntax = docker/dockerfile:1.2
# syntax = registry.erda.cloud/retag/dockerfile:1.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems feasible to upgrade to version 1.8.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, i set it to latest

# syntax = registry.erda.cloud/retag/dockerfile:latest

@sfwn
Copy link
Member

sfwn commented Jul 9, 2024

/approve

@sfwn sfwn merged commit 2ee57b9 into erda-project:master Jul 9, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants