Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: get instance info from labels #6383

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

CeerDecy
Copy link
Member

@CeerDecy CeerDecy commented Jul 2, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes:

Specified Reviewers:

/assign @iutx

ChangeLog

Language Changelog
🇺🇸 English get instance info from labels
🇨🇳 中文 通过新的Labels获取实例信息

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@erda-bot erda-bot requested a review from iutx July 2, 2024 03:46
Copy link

stale bot commented Jul 24, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jul 24, 2024
@stale stale bot closed this Aug 1, 2024
@CeerDecy CeerDecy reopened this Aug 1, 2024
@stale stale bot removed the wontfix label Aug 1, 2024
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.79%. Comparing base (5a424b2) to head (1327628).
Report is 48 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6383      +/-   ##
==========================================
+ Coverage   15.60%   15.79%   +0.18%     
==========================================
  Files        3677     3682       +5     
  Lines      312018   315577    +3559     
==========================================
+ Hits        48703    49847    +1144     
- Misses     257860   260190    +2330     
- Partials     5455     5540      +85     
Flag Coverage Δ
by-github-actions 15.79% <100.00%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...duler/executor/plugins/k8s/instanceinfosync/pod.go 4.13% <100.00%> (+4.13%) ⬆️

... and 39 files with indirect coverage changes

@CeerDecy CeerDecy force-pushed the feature/instance-info branch from 307de3f to c628cf8 Compare August 7, 2024 06:14
Copy link

stale bot commented Aug 28, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Aug 28, 2024
@CeerDecy CeerDecy removed the wontfix label Aug 29, 2024
Copy link

stale bot commented Sep 21, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Sep 21, 2024
@stale stale bot closed this Sep 30, 2024
@CeerDecy CeerDecy reopened this Sep 30, 2024
@stale stale bot removed the wontfix label Sep 30, 2024
Copy link

stale bot commented Oct 29, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 29, 2024
@CeerDecy CeerDecy removed the wontfix label Oct 30, 2024
Copy link

stale bot commented Nov 23, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 23, 2024
@CeerDecy CeerDecy removed the wontfix label Nov 28, 2024
Copy link

stale bot commented Dec 20, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Dec 20, 2024
@CeerDecy CeerDecy removed the wontfix label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants