Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: core erda k8s labels #6323

Open
wants to merge 37 commits into
base: master
Choose a base branch
from

Conversation

CeerDecy
Copy link
Member

What this PR does / why we need it:

add core erda k8s labels when update and create pod/service/deployment/daemonset

Which issue(s) this PR fixes:

Specified Reviewers:

/assign @iutx

ChangeLog

Language Changelog
🇺🇸 English add core erda k8s labels to pod/service/deployment/daemonset
🇨🇳 中文 为pod/service/deployment/daemonset添加core erda标签

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

Copy link
Member

@iutx iutx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CeerDecy CeerDecy requested a review from iutx March 27, 2024 07:44
Copy link

stale bot commented Apr 17, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 17, 2024
@stale stale bot closed this Apr 25, 2024
@iutx iutx removed the wontfix label Apr 30, 2024
@iutx iutx reopened this Apr 30, 2024
@erda-bot
Copy link
Member

Add assignees failed, err: Post "https://api.github.com/repos/erda-project/erda/pulls/6323/requested_reviewers": proxyconnect tcp: dial tcp 47.74.128.161:8888: connect: connection refused

Copy link
Member

@iutx iutx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

stale bot commented May 22, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label May 22, 2024
@iutx iutx removed the wontfix label May 23, 2024
@CeerDecy CeerDecy requested a review from iutx May 31, 2024 06:41
Copy link
Member

@iutx iutx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CeerDecy CeerDecy requested a review from iutx July 1, 2024 09:52
Copy link

stale bot commented Jul 26, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jul 26, 2024
@iutx iutx removed the wontfix label Jul 28, 2024
Copy link

stale bot commented Aug 18, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Aug 18, 2024
@CeerDecy CeerDecy removed the wontfix label Aug 19, 2024
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 26.20690% with 107 lines in your changes missing coverage. Please review.

Project coverage is 15.60%. Comparing base (c315ced) to head (f6fb151).
Report is 23 commits behind head on master.

Files with missing lines Patch % Lines
internal/tools/orchestrator/labels/labels.go 22.64% 35 Missing and 6 partials ⚠️
...trator/scheduler/executor/plugins/k8s/daemonset.go 0.00% 16 Missing ⚠️
internal/apps/msp/resource/utils/common.go 0.00% 15 Missing ⚠️
internal/tools/orchestrator/dbclient/msp_tenant.go 0.00% 9 Missing ⚠️
...rator/scheduler/executor/plugins/k8s/deployment.go 54.54% 5 Missing ⚠️
...nternal/tools/orchestrator/services/addon/addon.go 54.54% 4 Missing and 1 partial ⚠️
.../tools/orchestrator/services/addon/addon_deploy.go 0.00% 4 Missing and 1 partial ⚠️
internal/tools/orchestrator/utils/addon_utils.go 0.00% 5 Missing ⚠️
...estrator/scheduler/executor/plugins/k8s/service.go 50.00% 3 Missing ⚠️
...ernal/apps/msp/resource/deploy/handlers/handler.go 0.00% 2 Missing ⚠️
... and 1 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6323      +/-   ##
==========================================
+ Coverage   15.54%   15.60%   +0.05%     
==========================================
  Files        3682     3677       -5     
  Lines      312196   311662     -534     
==========================================
+ Hits        48545    48623      +78     
+ Misses     258197   257581     -616     
- Partials     5454     5458       +4     
Flag Coverage Δ
by-github-actions 15.60% <26.20%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ator/scheduler/executor/plugins/k8s/statefulset.go 44.25% <100.00%> (+0.70%) ⬆️
...tools/orchestrator/services/addon/addon_handler.go 33.65% <83.33%> (+0.31%) ⬆️
...ernal/apps/msp/resource/deploy/handlers/handler.go 5.37% <0.00%> (-0.03%) ⬇️
...estrator/scheduler/executor/plugins/k8s/service.go 21.76% <50.00%> (-2.31%) ⬇️
...rator/scheduler/executor/plugins/k8s/deployment.go 38.89% <54.54%> (+0.21%) ⬆️
...nternal/tools/orchestrator/services/addon/addon.go 12.27% <54.54%> (-1.99%) ⬇️
.../tools/orchestrator/services/addon/addon_deploy.go 28.00% <0.00%> (-0.25%) ⬇️
internal/tools/orchestrator/utils/addon_utils.go 0.00% <0.00%> (ø)
internal/tools/orchestrator/dbclient/msp_tenant.go 0.00% <0.00%> (ø)
internal/apps/msp/resource/utils/common.go 17.74% <0.00%> (-5.67%) ⬇️
... and 2 more

... and 22 files with indirect coverage changes

Copy link

stale bot commented Sep 18, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Sep 18, 2024
@CeerDecy CeerDecy removed the wontfix label Sep 18, 2024
Copy link

stale bot commented Oct 12, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 12, 2024
@CeerDecy CeerDecy removed the wontfix label Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants