Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactoring steve cache #6278

Merged
merged 10 commits into from
Jul 2, 2024
Merged

Conversation

CeerDecy
Copy link
Member

@CeerDecy CeerDecy commented Feb 20, 2024

What this PR does / why we need it:

feat: refactoring steve cache

Which issue(s) this PR fixes:

Specified Reviewers:

/assign @iutx

ChangeLog

Language Changelog
🇺🇸 English refactoring steve cache
🇨🇳 中文 使用gcache作为Steve客户端的缓存

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.72%. Comparing base (d9b6ef1) to head (6f1ab41).
Report is 72 commits behind head on master.

Current head 6f1ab41 differs from pull request most recent head b3861a0

Please upload reports for the commit b3861a0 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6278      +/-   ##
==========================================
+ Coverage   22.68%   22.72%   +0.03%     
==========================================
  Files        1835     1835              
  Lines      196656   196718      +62     
==========================================
+ Hits        44613    44701      +88     
+ Misses     146903   146868      -35     
- Partials     5140     5149       +9     

see 23 files with indirect coverage changes

Copy link

stale bot commented Mar 12, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 12, 2024
@CeerDecy CeerDecy changed the title fix: OOM caused by the steve in the cmp feat: refactoring steve cache Mar 13, 2024
@stale stale bot removed the wontfix label Mar 13, 2024
@CeerDecy CeerDecy marked this pull request as ready for review March 14, 2024 02:00
Copy link
Member

@iutx iutx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmd/erda-server/bootstrap.yaml Outdated Show resolved Hide resolved
internal/apps/cmp/steve/aggregator.go Outdated Show resolved Hide resolved
internal/apps/cmp/steve/aggregator.go Outdated Show resolved Hide resolved
internal/apps/cmp/steve/aggregator.go Outdated Show resolved Hide resolved
internal/apps/cmp/steve/aggregator.go Show resolved Hide resolved
internal/apps/cmp/steve/aggregator.go Outdated Show resolved Hide resolved
internal/apps/cmp/steve/aggregator.go Outdated Show resolved Hide resolved
internal/apps/cmp/steve/aggregator.go Outdated Show resolved Hide resolved
internal/apps/cmp/steve/aggregator.go Outdated Show resolved Hide resolved
internal/apps/cmp/steve/aggregator.go Show resolved Hide resolved
@CeerDecy CeerDecy requested a review from iutx March 19, 2024 10:01
Copy link

stale bot commented Apr 12, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 12, 2024
@stale stale bot closed this Apr 19, 2024
@CeerDecy CeerDecy reopened this May 31, 2024
@stale stale bot removed the wontfix label May 31, 2024
iutx
iutx previously approved these changes Jun 6, 2024
Copy link
Member

@iutx iutx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM
PTAL :) @sfwn

Copy link

stale bot commented Jun 27, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 27, 2024
@iutx iutx removed the wontfix label Jul 2, 2024
@iutx iutx requested a review from sfwn July 2, 2024 05:24
@iutx
Copy link
Member

iutx commented Jul 2, 2024

@sfwn PTAL

Copy link
Member

@sfwn sfwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handle errors in more detail.

cmd/erda-server/bootstrap.yaml Show resolved Hide resolved
internal/apps/cmp/steve/aggregator.go Show resolved Hide resolved
internal/apps/cmp/steve/aggregator.go Outdated Show resolved Hide resolved
internal/apps/cmp/steve/aggregator.go Show resolved Hide resolved
@sfwn
Copy link
Member

sfwn commented Jul 2, 2024

/approve

@sfwn sfwn merged commit 1d5d1d6 into erda-project:master Jul 2, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants