Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dop): iteration support label relation #5992

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

chengjoey
Copy link
Contributor

What this PR does / why we need it:

iteration support label relation

Which issue(s) this PR fixes:

Specified Reviewers:

/assign @sfwn

ChangeLog

Language Changelog
🇺🇸 English iteration support label relation
🇨🇳 中文 支持迭代与标签进行关联

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@erda-bot erda-bot added dop devops plaoform feature labels Jul 19, 2023
@erda-bot erda-bot requested a review from sfwn July 19, 2023 10:06
@chengjoey chengjoey force-pushed the feat/iteration-label branch 2 times, most recently from 42fa6e1 to 0e93695 Compare July 20, 2023 06:27
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #5992 (8f23bb2) into master (6581d3b) will decrease coverage by 0.02%.
The diff coverage is 20.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5992      +/-   ##
==========================================
- Coverage   22.21%   22.20%   -0.02%     
==========================================
  Files        1880     1880              
  Lines      208507   208565      +58     
==========================================
- Hits        46318    46305      -13     
- Misses     156892   156969      +77     
+ Partials     5297     5291       -6     
Impacted Files Coverage Δ
apistructs/iteration.go 100.00% <ø> (ø)
internal/apps/dop/endpoints/iteration.go 6.63% <20.00%> (-5.93%) ⬇️

... and 3 files with indirect coverage changes

@@ -110,6 +114,8 @@ type IterationPagingRequest struct {
WithoutIssueSummary bool `schema:"withoutIssueSummary"`
// +optional
IDs []uint64 `json:"ids" schema:"id"`
// +optional
Labels []uint64 `json:"labels" schema:"labels"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LabelIDs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adjusted

@@ -36,6 +36,8 @@ type IterationCreateRequest struct {

ManHour *IssueManHour `json:"manHour"`

Labels []string `json:"labels"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be labelIDs

@sfwn
Copy link
Member

sfwn commented Jul 20, 2023

/approve

@sfwn sfwn merged commit 13ba6a4 into erda-project:master Jul 21, 2023
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants