-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dop): iteration support label relation #5992
Conversation
42fa6e1
to
0e93695
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5992 +/- ##
==========================================
- Coverage 22.21% 22.20% -0.02%
==========================================
Files 1880 1880
Lines 208507 208565 +58
==========================================
- Hits 46318 46305 -13
- Misses 156892 156969 +77
+ Partials 5297 5291 -6
|
apistructs/iteration.go
Outdated
@@ -110,6 +114,8 @@ type IterationPagingRequest struct { | |||
WithoutIssueSummary bool `schema:"withoutIssueSummary"` | |||
// +optional | |||
IDs []uint64 `json:"ids" schema:"id"` | |||
// +optional | |||
Labels []uint64 `json:"labels" schema:"labels"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LabelIDs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adjusted
@@ -36,6 +36,8 @@ type IterationCreateRequest struct { | |||
|
|||
ManHour *IssueManHour `json:"manHour"` | |||
|
|||
Labels []string `json:"labels"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be labelIDs
0e93695
to
8f23bb2
Compare
/approve |
What this PR does / why we need it:
iteration support label relation
Which issue(s) this PR fixes:
Specified Reviewers:
/assign @sfwn
ChangeLog
Need cherry-pick to release versions?
Add comment like
/cherry-pick release/1.0
when this PR is merged.