Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hepa): fix key-auth for mse and nginx check for kong #5976

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

wangzhuzhen
Copy link
Contributor

What this PR does / why we need it:

Fix 3 bugs:
(1) Lack of credential for default config for mse key-auth plugin.
(2) MSE gateway redirect type url support modify
(3) Nginx custom config conflict check

Specified Reviewers:

/assign @dspo @luobily

ChangeLog

Bugfix: Fix the bug that some configurations for MSE or Nginx-Kong Gateway(修复了 MSE key-auth 和 Kong 自定义 Nginx 配置校验的问题)

Language Changelog
🇺🇸 English Fix the bug that some configurations for MSE or Nginx-Kong Gateway
🇨🇳 中文 修复了 MSE 和 Kong 自定义 Nginx 配置校验的问题

Need cherry-pick to release versions?

/cherry-pick release/2.4-beta.1

@erda-bot erda-bot added bugfix hepa ingress management labels Jul 10, 2023
@erda-bot
Copy link
Member

Automated cherry pick can ONLY be triggered when this PR is MERGED!

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #5976 (e1895f1) into master (3dc8924) will increase coverage by 0.01%.
The diff coverage is 28.88%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5976      +/-   ##
==========================================
+ Coverage   22.18%   22.19%   +0.01%     
==========================================
  Files        1880     1880              
  Lines      208425   208472      +47     
==========================================
+ Hits        46231    46272      +41     
- Misses     156903   156905       +2     
- Partials     5291     5295       +4     
Impacted Files Coverage Δ
...rator/hepa/gateway-providers/mse/plugins/common.go 33.23% <ø> (ø)
...chestrator/hepa/services/endpoint_api/impl/impl.go 2.63% <27.50%> (+0.37%) ⬆️
...orchestrator/hepa/services/api_policy/impl/impl.go 8.90% <40.00%> (-0.06%) ⬇️

... and 10 files with indirect coverage changes

@luobily
Copy link
Member

luobily commented Jul 12, 2023

/approve

@erda-bot erda-bot merged commit bad04b6 into erda-project:master Jul 12, 2023
@luobily
Copy link
Member

luobily commented Jul 12, 2023

/cherry-pick release/2.4-beta.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved bugfix hepa ingress management
Development

Successfully merging this pull request may close these issues.

3 participants