-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(hepa): fix key-auth for mse and nginx check for kong #5976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automated cherry pick can ONLY be triggered when this PR is MERGED! |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5976 +/- ##
==========================================
+ Coverage 22.18% 22.19% +0.01%
==========================================
Files 1880 1880
Lines 208425 208472 +47
==========================================
+ Hits 46231 46272 +41
- Misses 156903 156905 +2
- Partials 5291 5295 +4
|
luobily
reviewed
Jul 12, 2023
/approve |
erda-bot
approved these changes
Jul 12, 2023
/cherry-pick release/2.4-beta.2 |
erda-bot
pushed a commit
to erda-bot/erda
that referenced
this pull request
Jul 12, 2023
erda-bot
added a commit
that referenced
this pull request
Jul 12, 2023
Co-authored-by: wang zhuzhen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fix 3 bugs:
(1) Lack of credential for default config for mse key-auth plugin.
(2) MSE gateway redirect type url support modify
(3) Nginx custom config conflict check
Specified Reviewers:
/assign @dspo @luobily
ChangeLog
Bugfix: Fix the bug that some configurations for MSE or Nginx-Kong Gateway(修复了 MSE key-auth 和 Kong 自定义 Nginx 配置校验的问题)
Need cherry-pick to release versions?
/cherry-pick release/2.4-beta.1