Skip to content

Commit

Permalink
polish: use constant addon name
Browse files Browse the repository at this point in the history
Signed-off-by: CeerDecy <[email protected]>
  • Loading branch information
CeerDecy committed Oct 24, 2024
1 parent 714ed11 commit 2cef038
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 2 additions & 0 deletions apistructs/addon.go
Original file line number Diff line number Diff line change
Expand Up @@ -334,6 +334,8 @@ const (
AddonRegisterCenter = "registercenter"
// mse-nacos
AddonMSENacos = "mse-nacos"
// custom
AddonCustom = "custom"
)

// AddonRes addon信息
Expand Down
4 changes: 2 additions & 2 deletions internal/tools/orchestrator/services/addon/addon.go
Original file line number Diff line number Diff line change
Expand Up @@ -2707,13 +2707,13 @@ func (a *Addon) ListCustomAddon() (*[]map[string]interface{}, error) {
switch item.Name {
case apistructs.AddonMySQL, apistructs.AddonApiGateway, apistructs.AddonMonitor, apistructs.AddonRegisterCenter, apistructs.AddonNewConfigCenter:

Check warning on line 2708 in internal/tools/orchestrator/services/addon/addon.go

View check run for this annotation

Codecov / codecov/patch

internal/tools/orchestrator/services/addon/addon.go#L2708

Added line #L2708 was not covered by tests
addonMap["vars"] = nil
case "canal":
case apistructs.AddonCanal:

Check warning on line 2710 in internal/tools/orchestrator/services/addon/addon.go

View check run for this annotation

Codecov / codecov/patch

internal/tools/orchestrator/services/addon/addon.go#L2710

Added line #L2710 was not covered by tests
addonMap["vars"] = []string{
"canal.instance.master.address",
"canal.instance.dbUsername",
"canal.instance.dbPassword",
"mysql"}
case "custom":
case apistructs.AddonCustom:

Check warning on line 2716 in internal/tools/orchestrator/services/addon/addon.go

View check run for this annotation

Codecov / codecov/patch

internal/tools/orchestrator/services/addon/addon.go#L2716

Added line #L2716 was not covered by tests
addonMap["vars"] = []string{}
}
addonMap["plan"] = createableAddonPlan[item.Name]
Expand Down

0 comments on commit 2cef038

Please sign in to comment.