Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delta relative to date within ensemble SimulationTimeSeries #951

Merged
merged 35 commits into from
Feb 11, 2022
Merged

Delta relative to date within ensemble SimulationTimeSeries #951

merged 35 commits into from
Feb 11, 2022

Conversation

jorgenherje
Copy link
Collaborator

@jorgenherje jorgenherje commented Feb 8, 2022 •
edited
Loading

Calculate delta relative to date within ensemble for SimulationTimeSeries-plugin

Contributor checklist

  • Selectable dates in dropdown - union of dates from all EnsembleSummaryProvider's in provider set
  • Calculate vector data in dataframes relative to selected date - if date does not exist -> return empty df
  • Calculate statistics afterwards, i.e. "resetting" the statistics calculation!
  • Assume set of realizations to exist for each date in an ensemble, i.e. all realizations exist for all dates in an ensemble. Will need updated provider-interface.

NOTE:

@jorgenherje
Prototyping backup
9c88ba5
@jorgenherje
Furhter implementation
cf41b23 
- Use naming "VectorDefinition"
- Adjust to "AVG_" -> "PER_DAY_" and "INTVL_" -> "PER_INTVL_"
@jorgenherje
isort
facffa6
@jorgenherje
Add utils, typehint and correct naming
22a7916
@jorgenherje
Merge commit 'c73a699e1e31b2efa384cba3e0b8ad5f2d1cb586' into EQ_698-u…
1710a0a 
…ser-defined-vector-definition
@jorgenherje
Refactor code and update unit tests
645e33c 
- Update unit tests according to "PER_DAY_" and "PER_INTVL_" notation
- Bug fix (missing well name in plot title)
- Refactor methods
@jorgenherje
Fix isort import
30ec478
@jorgenherje
Add unit test for simulation_vector_description() method
4318daa 
Add unit test for refactored simulation_vector_description() method in
reservoir_simulation.py
@jorgenherje
Clearyfi comment
a0fd537
@jorgenherje
Sort imports with isort
71d1901
@jorgenherje
Delete reservoir_simulation_vectors.json
25caa4d 
Adapted to utilize VectorDefinitions from webviz-subsurface-components
Python-API
@jorgenherje
Merge commit 'e759bc691a39b376570a0e4f0197e6f97853508a' into EQ_698-u…
cbb9450 
…ser-defined-vector-definition
@jorgenherje
Fix code style & linting
bf6a891
@jorgenherje
Added changelog
e515856 
Correct changelog - "Added" and "Changed" info

Fix typo
@jorgenherje
Fix minor SettingWithCopyWarning bug
43890ed 
- When downloading statistics, .loc  gave SettingWithCopyWarning warning.
- Remove usage of .loc as chained index is not needed: ["DATE"] instead of
[("DATE", "")].
- Make copy as download is not performance critical and statistics df
contains less data.
@jorgenherje
Merge commit '415d8697bdba9c999bffab6a8286e957b46a2ffb' into EQ_698-u…
b617f9a 
…ser-defined-vector-definition
@jorgenherje
Data relative to date - Prototype implementation
8ab82ff
@jorgenherje
Minor adjustment and add demo date for testing
492c4cc
@jorgenherje
Next iteration prototype
1af4219
@jorgenherje
Next iteration
3c5f531 
Testing improved implementation of relative to date calculation
@jorgenherje
Furhter prototype implementation for testing
c58b908 
- Improved calculation methods
- Created new implementations of calculation, and testing with timers.
- Moved methods into utils-folder
@jorgenherje
Finalize implementation for PR
5c30c38 
- Set calculation method for data relative to date: Assuming
set of realizatios equal on each date for an ensemble - providers
are to be updated!
- Add unit tests
- Clean up code
- Add relative date selection to user download data callback
@jorgenherje
Merge branch 'master' into EQ_698-delta-relative-to-date-within-ensemble
92f6127
@jorgenherje jorgenherje added enhancement 🚀 New feature or request CeeSol Task owned by Ceetron Solutions labels Feb 8, 2022
@jorgenherje jorgenherje self-assigned this Feb 8, 2022
@jorgenherje jorgenherje mentioned this pull request Feb 8, 2022
Closed
anders-kiaer
anders-kiaer requested changes Feb 10, 2022
View reviewed changes
Copy link
Collaborator

@anders-kiaer anders-kiaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small comments, otherwise LGTM! 👏 🚀

webviz_subsurface/plugins/_simulation_time_series/utils/vector_statistics.py Outdated Show resolved Hide resolved
webviz_subsurface/plugins/_simulation_time_series/utils/dataframe_utils.py Outdated Show resolved Hide resolved
webviz_subsurface/plugins/_simulation_time_series/_callbacks.py Outdated Show resolved Hide resolved
webviz_subsurface/plugins/_simulation_time_series/_callbacks.py Outdated Show resolved Hide resolved
@anders-kiaer anders-kiaer changed the title Delta relative to date within ensemble SimulationTimeSeries Delta relative to date within ensemble SimulationTimeSeries Feb 10, 2022
@jorgenherje jorgenherje merged commit 9609bb0 into equinor:master Feb 11, 2022
VincentNevermore pushed a commit to VincentNevermore/webviz-subsurface that referenced this pull request Jul 19, 2022
@nilscb
Optional property to specify a colormap function that will override t… (
b5feb17 
equinor#951)

* Optional property to specify a colormap function that will override the colormap.

* Added storybook example.

* Code comment fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anders-kiaer anders-kiaer anders-kiaer approved these changes

@asnyv asnyv Awaiting requested review from asnyv

Assignees

@jorgenherje jorgenherje

Labels
CeeSol Task owned by Ceetron Solutions enhancement 🚀 New feature or request
Projects
Webviz
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jorgenherje @anders-kiaer