Move `SerializeForVersion` to `dto` module and remove wrapper structs around common types #2459

t00ts · 2024-12-24T09:33:40Z

This PR is part of #2220

Summary

Moves SerializeForVersion to dto module
Remove all wrapper structs around common types in dto module
Removes SerializationForVersion blanket implementation for serde

Closes #2181
Closes #2220
Closes #2048
Closes #2047

crates/common/src/macros.rs

crates/executor/src/types.rs

crates/rpc/src/dto/class.rs

crates/rpc/src/dto.rs

crates/rpc/src/method/get_block_with_txs.rs

crates/rpc/src/pathfinder/methods/get_proof.rs

crates/rpc/src/types/class.rs

…or serde

CHr15F0x

Ah, forgot to approve: 👍 , those comments of mine were just nits that I noticed here and there.

t00ts added 2 commits January 7, 2025 13:43

chore(rpc): move SerializeForVersion into the dto module

926fbb5

feat(rpc/dto): remove dto wrappers for common types

f40f3a2

t00ts force-pushed the t00ts/rpc-serializeforversion-common-types branch from 617bf8a to 5b8bcd7 Compare January 7, 2025 09:44

t00ts marked this pull request as ready for review January 7, 2025 09:44

t00ts requested a review from a team as a code owner January 7, 2025 09:44

t00ts force-pushed the t00ts/rpc-serializeforversion-common-types branch from 5b8bcd7 to 677d06a Compare January 7, 2025 09:49

vbar reviewed Jan 7, 2025

View reviewed changes

crates/common/src/macros.rs Show resolved Hide resolved

t00ts force-pushed the t00ts/rpc-serializeforversion-common-types branch 2 times, most recently from 66072ad to dbca79f Compare January 7, 2025 12:44

CHr15F0x reviewed Jan 7, 2025

View reviewed changes

crates/executor/src/types.rs Outdated Show resolved Hide resolved

vbar reviewed Jan 8, 2025

View reviewed changes

crates/rpc/src/dto/class.rs Show resolved Hide resolved

vbar approved these changes Jan 8, 2025

View reviewed changes