Board controller authorizations tests #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
either a Postgrex error (:user_not_found) or :no_sessions
checks if there are any active sessions for user_id
for tests requiring a user that is not logged in
:user_not_found error :no_sessions error
in the case that old and new ttl's are invalid, set to max expiry this ensures keys are all eventually expired regardless of given ttl validity
update writing code section later with doc refactor
since ban key can be empty, it is possible that old TTL is -2 which is a valid number, but will expire the ban key immediately when set
since moderating key can be empty, it is possible that old TTL is -2 which is a valid number, but will expire the moderating key immediately when set
needs to check if attrs contains any two keys, not all keys
implement map_contains_any_two_keys_in_list
uses guard clause for checking empty map
(a match on %{} matches any map)
use map_contains_any_two_keys_in_list
Validate mutually exclusive fixes
Validate mutually exclusive
…ler-authorizations
can be used for checking acl's (private user can only access motd)
Session test
… into board-controller-authorizations-tests resolve conflicts
akinsey
approved these changes
Nov 6, 2023
|
🎉 This PR is included in version 1.23.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add tests for board controller authorizations
update with latest main changes
refactor + bug fixes