Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mentions regex #72

Merged
merged 32 commits into from
Oct 24, 2023
Merged

Mentions regex #72

merged 32 commits into from
Oct 24, 2023

Conversation

unenglishable
Copy link
Member

update mentions regex to work correctly

separate regex into its own module

test mentions regex

test mentions username_to_user_id

@unenglishable
feat(regex): add regex.ex
d3ac000 
consolidated source for hard-coded regex patterns
@unenglishable
test(regex): add test for regex
95ead40 
test existing and nonexistent patterns
@unenglishable
test(regex): refactor test names to match guidelines
0bed58c
@unenglishable
test(regex): add test string attribute
c53a0de
@unenglishable
test(regex): test regex scan for username_mention
a158c2b
@unenglishable
test(regex): use Enum.each for checking usernames
31b1717
@unenglishable
test(regex): extract usernames from test, into attribute
5fd9379
@unenglishable
test(regex): check :username_mention_curly
31dae2e
@unenglishable
test(regex): mix format
16fd728
@unenglishable
test(regex): check that mention can have a trailing comma
cffe578
@unenglishable
test(regex): test mixed case mention
07857c1
@unenglishable
fix(regex): user_id; remove bol from pattern, use 0-9 instead of [:di…
7e84f5a 
…git]
@unenglishable
test(regex): create test for :user_id pattern
3486a18 
map mentions to curly brace, then user_id mentions

regex scan for :user_id pattern in string

check matches using re-mapped usernames -> id list
@unenglishable
test(regex): split test for mentions out
0fe5d03
@unenglishable
test(regex): refactor module attribute names for mentions test
4bdf2d3
@unenglishable
test(regex): mix format
2364a24
@unenglishable
test(regex): move attributes near mentions test
4659d9c
@unenglishable
test(regex): remove unnecessary id_to_username_map
f226160 
not actually converting id's back to usernames

mapping @mentions_usernames to id's instead
@unenglishable
refactor(models/mention): use EpochtalkServer.Regex.pattern
b410f31
@unenglishable
test(models/mention): add mention test
ca36d67
@unenglishable
test(models/mention): username_to_user_id/2
26e4cea 
check invalid mentions do not get generated
@unenglishable
test(models/mention): test valid mentions get generated
d0cb639
@unenglishable
test(models/mention): check that all user ids are present in mentione…
1f31baa 
…d_ids
@unenglishable
test(models/mention): check behavior on empty user
6396f3e
@unenglishable
test(models/mention): refactor invalid user body
100daec
@unenglishable
test(models/mention): test invalid thread id
3322c65
@unenglishable
test(models/mention): test empty body
9dd102a
@unenglishable
test(models/mention): test user without acl permission
c60f356
@unenglishable
test(models/mention): add note for duplicate mention
7effba3
@unenglishable
test(models/mention): test empty title
e76818f
@akinsey akinsey merged commit b3547ef into posts-by-thread Oct 24, 2023
5 checks passed
@akinsey akinsey deleted the mentions-regex branch October 24, 2023 19:48
@unenglishable unenglishable mentioned this pull request Oct 26, 2023
Closed
@github-actions
Copy link

🎉 This PR is included in version 1.19.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akinsey akinsey akinsey approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@unenglishable @akinsey