Posts by thread #71
Merged
Posts by thread #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… feature for posts
…uto moderator assigns them
…gres disconnecting randomly
…requests that modify the database
…ted before tracking ip
resolves issue from fresh install board.board.meta is not filled, also check board.stats
base 64 encoding can have / in it and possibly other characters that will cause verification URL to be invalid and error base 16 only contains alphanumeric with capital letters, will not cause a bad url to be generated
Model changes: checks if user's confirmation token matches supplied confirmation token if tokens match, return true and delete confirmation token off of model in database if tokens don't match, return false Controller changes: use new model function to check token match instead of in controller (tell don't ask) use return values (boolean) to match in `with` to check for success
…, helps optimize mentions
…or creating mentions
…bject remove idea of decoded token - this is an outdated notion from the legacy project id is used as the resource initially to set the subject for token. it will be updated later with session info
…f user_id, check self moderation in thread create
…ating post, this was not in the old code
… have permission to moderate before creating thread
…_mode expired without expiration set
…e, still need to handle parsing and image processing
Mentions regex
…merging boka branch
|
|
||
| @postgres_varchar255_max 255 | ||
| @postgres_varchar1000_max 1000 | ||
| @hours 24 |
There was a problem hiding this comment.
hours_per_day, minutes_per_hour, second_per_minute
| render(conn, :create, %{thread_data: thread_data}) | ||
| else | ||
| {:error, %Ecto.Changeset{} = cs} -> | ||
| ErrorHelpers.render_json_error(conn, 400, cs) | ||
|
|
||
| {:can_read, {:ok, false}} -> | ||
| ErrorHelpers.render_json_error(conn, 403, "Unauthorized, you do not have permission") |
There was a problem hiding this comment.
maybe differentiate between these 403's , they have the same message
| def maybe_update_last_active(nil), do: {:ok, nil} | ||
| def maybe_update_last_active(%{user_id: user_id}), do: maybe_update_last_active(%{id: user_id}) | ||
|
|
||
| def maybe_update_last_active(%{id: user_id} = user) when is_map(user) do |
unenglishable
approved these changes
Oct 26, 2023
|
🎉 This PR is included in version 1.19.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.