Change exit code for p2p -h #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, I missed this PR somehow. I don't disagree wrt. '-h'. Note though that this |
ralphlange
force-pushed
the
master
branch
2 times, most recently
from
219df27
to
3e59a4b
Compare
added 2 commits
September 9, 2019 13:10
Running "p2p -h" should exit with code 0, not 1. It's a valid flag.
beenje
force-pushed
the
p2p_exit_code
branch
from
93e9c38
to
b054b6d
Compare
|
You comment got a bit lost during my vacation. You never know what people are gonna do with your code ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running "p2p -h" should exit with code 0, not 1.
It's a valid flag.