Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup CI for jdk 8 and 9 #17

Merged
merged 15 commits into from
Oct 3, 2018
Merged

setup CI for jdk 8 and 9 #17

merged 15 commits into from
Oct 3, 2018

Conversation

shroffk
Copy link
Contributor

@shroffk shroffk commented Jun 25, 2018

#13 and #16

@shroffk shroffk requested a review from ralphlange June 25, 2018 14:53
@shroffk
Copy link
Contributor Author

shroffk commented Jun 25, 2018

@mrkraimer
It seems like there are errors in the pvDatabaseJava and pvClientJava.
These errors are related to the html encoding used to create the javadoc's

[ERROR] Exit code: 1 - /home/travis/build/epics-base/epicsCoreJava/pvDatabaseJava/documentation/pvDatabaseJava.html:163: error: self-closing element not allowed

@georgweiss worked recently on fixing similar errors for the main modules.
#14
Could you copy these changes so that we can enable CI against java 8, 9, and 10

Copy link
Contributor

@ralphlange ralphlange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. That looks great.

@ralphlange
Copy link
Contributor

What about merging this and restart the PR build(s) for Georg's changes?!

@georgweiss
Copy link
Contributor

Please merge PR epics-base/directoryService#2 to resolve this.

@shroffk
Copy link
Contributor Author

shroffk commented Jun 26, 2018

@georgweiss thanks...I did accept the PR and it seems like it has solved the problem

@shroffk
Copy link
Contributor Author

shroffk commented Aug 6, 2018

We might want to add jdk10 and 11 to the list and move to openJDK instead of oracle jdk

@ralphlange
Copy link
Contributor

Movie sounds great. I'm in.

@georgweiss
Copy link
Contributor

Are you removing Oracle JDK from the CI builds? We're using it here at ESS.

@shroffk shroffk mentioned this pull request Aug 6, 2018
@shroffk
Copy link
Contributor Author

shroffk commented Sep 26, 2018

In preparation for moving the epics core projects to java 10+ the CI was updated to run on open and oracle versions of java starting from 8 to 11

At the last build all problems related to the javadoc production have been resolved.
https://travis-ci.org/epics-base/epicsCoreJava/builds/433584801

The only open issue is that openjfx is no longer available for trusty. It is available for xenial and bionic distributions of ubuntu.

* Update .travis.yml

* removing the typo "-"
@shroffk
Copy link
Contributor Author

shroffk commented Sep 27, 2018

@georgweiss @ralphlange I finally have the CI builds succeeding.
Some things are not perfect, see above comment...but I think for the time being this can be merged.

Should these commits be squashed??

@ralphlange
Copy link
Contributor

Yes, Please squash and merge.

@shroffk shroffk merged commit bdba05e into master Oct 3, 2018
shroffk added a commit that referenced this pull request Oct 3, 2018
* setup CI for jdk 8 and 9

* Update .travis.yml

* Update .travis.yml

* updating pvDatabaseJava module

* #16 fixing javadoc preparing for java 9

* Updating exampleJava for jdk9 compliance

* Temporarily disabling test due to travis failures

* #16 install openfx and fix certificates for jdk8 and jdk10

* Update .travis.yml

* Temporarily disable unit test failing on travis

* #16 cleaning up the java doc plugin and adding html5 tag

* remove references to com.sun.* deprecated in java9+

* #16 using george's profile to disable html5 for java8

* Travis patch (#24)

* Update .travis.yml

* removing the typo "-"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants