Skip to content

Commit

Permalink
Merge branch 'CW-3551' into 'dev'
Browse files Browse the repository at this point in the history
reduce max memory requested by 1 GB to not fail in WSL or the cloud [CW-3551]

Closes CW-3551

See merge request epi2melabs/workflows/wf-alignment!128
  • Loading branch information
julibeg committed Feb 15, 2024
2 parents b2351e4 + b12dd3b commit f47e189
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 8 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [v1.1.1]
### Changed
- Reduced the memory requested by some processes to avoid failing in WSL (since there is slightly less memory available in WSL than specified in `.wslconfig`).

## [v1.1.0]
### Changed
- Some formatting changes to github issue template.
Expand Down
12 changes: 6 additions & 6 deletions main.nf
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ process makeMMIndex {
cpus params.threads
memory {
def ref_size = combined_refs.size()
combined_refs.size() > 1e9 ? "32 GB" : "12 GB"
combined_refs.size() > 1e9 ? "31 GB" : "11 GB"
}
input:
path combined_refs, stageAs: "combined_references.fasta"
Expand All @@ -38,7 +38,7 @@ process checkReferences {
cpus params.threads
memory {
def ref_size = combined_refs.size()
combined_refs.size() > 1e9 ? "32 GB" : "12 GB"
combined_refs.size() > 1e9 ? "31 GB" : "11 GB"
}
input:
path "combined_references.mmi"
Expand All @@ -57,7 +57,7 @@ process alignReads {
label "wfalignment"
cpus params.threads
memory {
combined_refs.size() > 1e9 ? "32 GB" : "12 GB"
combined_refs.size() > 1e9 ? "31 GB" : "11 GB"
}
input:
tuple val(meta), path(input)
Expand Down Expand Up @@ -135,7 +135,7 @@ process readDepthPerRef {
// TODO: check if parallelisation with `xargs` or `parallel` is more efficient
label "wfalignment"
cpus 3
memory "8 GB"
memory "7 GB"
input:
tuple val(meta), path(alignment), path(index)
path ref_len
Expand All @@ -161,7 +161,7 @@ process readDepthPerRef {
process makeReport {
label "wfalignment"
cpus 1
memory "12 GB"
memory "11 GB"
input:
path "readstats/*"
path "flagstat/*"
Expand Down Expand Up @@ -345,7 +345,7 @@ process output {
process configure_jbrowse {
label "wfalignment"
cpus 1
memory { reference.size() > 1e9 ? "16 GB" : "2 GB" }
memory { reference.size() > 1e9 ? "15 GB" : "2 GB" }
input:
path(alignments)
path(indexes)
Expand Down
2 changes: 1 addition & 1 deletion nextflow.config
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ manifest {
description = 'Align Nanopore reads and visualize mapping statistics.'
mainScript = 'main.nf'
nextflowVersion = '>=23.04.2'
version = 'v1.1.0'
version = 'v1.1.1'
}

epi2melabs {
Expand Down
2 changes: 1 addition & 1 deletion subworkflows/process_references.nf
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ process combine {
process fx2tab {
label "wfalignment"
cpus 1
memory { reference.size() > 1e9 ? "16 GB" : "2 GB" }
memory { reference.size() > 1e9 ? "15 GB" : "2 GB" }
input:
path reference
output:
Expand Down

0 comments on commit f47e189

Please sign in to comment.