EPMUII-8073-Zoom-in/out-improvements #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleksandr-iefymchuk
force-pushed
the
EPMUII-8073-Zoom-in/out-improvements
branch
from
9e0372a to
0de4a16
Compare
oleksandr-iefymchuk
force-pushed
the
EPMUII-8073-Zoom-in/out-improvements
branch
4 times, most recently
from
452c2f7 to
fa93143
Compare
DanilRostov
requested changes
Nov 13, 2023
src/ui/UiZoomTools.jsx
Outdated
| const mediator = (buttonId) => { | ||
| setActiveButton(buttonId); | ||
| props.dispatch({ type: StoreActionType.SET_2D_TOOLS_INDEX, indexTools2d: buttonId }); | ||
|
|
||
| if (buttonId === Tools2dType.ZOOM_100) { | ||
| if (buttonId === Tools2dType.ZOOM_100 || (buttonId === Tools2dType.ZOOM_OUT && props.render2dZoom > 0.8)) { |
There was a problem hiding this comment.
Let's create meaningful variable for 0.8 value
src/engine/Graphics2d.js
Outdated
| // ctx.imageSmoothingEnabled = true; | ||
|
|
||
| // ctx.putImageData(this.imgData, 0, 0); | ||
| // ctx.drawImage(objCanvas, xPos, yPos, canvasWidth, canvasHeight, 0, 0, newImgWidth, newImgHeight); |
There was a problem hiding this comment.
Please remove outdated code, or leave description why it was commented
oleksandr-iefymchuk
force-pushed
the
EPMUII-8073-Zoom-in/out-improvements
branch
from
5a49855 to
46a91cc
Compare
DanilRostov
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.