Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Chain displays the total number of C atoms during mouseMove #6101

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mySkey
Copy link

@mySkey mySkey commented Dec 9, 2024

How the feature works? / How did you fix the issue?

(Screenshots, videos, or GIFs, if applicable)

The chain displays the total number of C atoms during mouseMove, and follows the original logic during mouseUp because we need to know the length of the chain, otherwise we have to count them one by one

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

@svvald
Copy link
Collaborator

svvald commented Dec 10, 2024

Hello @mySkey, thank you for your contribution! This is a valuable improvement, which definitely comes in handy. While the overall implementation looks good and we will certainly use it, we also need to discuss it within our team, probably we might want to come up with a slightly different appearance for atoms counter

ETA on delivering this feature in the upcoming release is mid-January, please let us know if it's critical for you current operations, we might be able to prepare a dev release for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants