-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#5497 – Refactor (SnakeModePolymerBondRenderer): Create SnakeModeSideChainBondRenderer
#6033
Open
DmitriiP-EPAM
wants to merge
26
commits into
master
Choose a base branch
from
5497-refactor-split-logic-of-snakemodepolymerbondrenderer-by-several-classes--3.1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ChainConnectionBondRenderer`
…akemodepolymerbondrenderer-by-several-classes--3.1 # Conflicts: # packages/ketcher-core/src/application/render/renderers/RenderersManager.ts # packages/ketcher-core/src/domain/entities/PolymerBond.ts
DmitriiP-EPAM
commented
Dec 3, 2024
...core/src/application/render/renderers/PolymerBondRenderer/SideChainConnectionBondRenderer.ts
Outdated
Show resolved
Hide resolved
DmitriiP-EPAM
commented
Dec 4, 2024
...er-core/src/application/render/renderers/PolymerBondRenderer/SnakeModePolymerBondRenderer.ts
Outdated
Show resolved
Hide resolved
…deConnectionBondTurnPoint` update
…EndOfPathPart(1)`
…aces for `drawPartOfSideConnection(1)`
… `.attr('stroke-dasharray', '0')`
…akemodepolymerbondrenderer-by-several-classes--3.1
DmitriiP-EPAM
changed the title
#5497 – Refactor:
#5497 – Refactor (SnakeModePolymerBondRenderer): Create Dec 6, 2024
SnakeModePolymerBondRenderer
SnakeModeSideChainBondRenderer
auto-assign
bot
requested review from
AlexeyGirin,
NataliaLoginova and
svvald
December 6, 2024 15:34
…ideConnectionBondTurnPoint(1)`
DmitriiP-EPAM
added
technical debt
refactor
Code refactoring, without changing the functionality
labels
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
(Screenshots, videos, or GIFs, if applicable)
Check list
#1234 – issue name