#4802 - Copy/Past operation works wrong #4910
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NataliaLoginova
approved these changes
Jun 28, 2024
NataliaLoginova
requested review from
svvald and
rrodionov91
and removed request for
rrodionov91
svvald
reviewed
Jul 1, 2024
| if (sg.atoms.some((aid) => !atomSet!.has(aid))) return; | ||
| const notInGroup = sg.atoms.some((aid) => !atomSet!.has(aid)); | ||
| const atomsInSet = sg.atoms.filter((aid) => atomSet!.has(aid)); | ||
| if (!atomsInSet.length && notInGroup) return; |
There was a problem hiding this comment.
Maybe I'm missing something here but why do you need notInGroup? Conditions in .some and .filter are mutually exclusive so if there are no elements satisfying the atomSet.has(aid) condition, there is definitely at least one element which satisfies the inverse !atomSet.has(aid) condition
There was a problem hiding this comment.
Sometimes (when we copy a attachment point label) we are not in the group, but we need still filter some atoms,
but if we are not in the group and there are no atoms, we exit. Also, we must support the previous realization of mergeInto.
Perhaps there is another way to solve the problem.
Guch1g0v
changed the title
Guch1g0v
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
(Screenshots, videos, or GIFs, if applicable)
Check list
#1234 – issue name