Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Split logic of SnakeModePolymerBondRenderer by several classes #5497

Open
DmitriiP-EPAM opened this issue Sep 11, 2024 · 1 comment · Fixed by #5498 · May be fixed by #6033
Open

Refactor: Split logic of SnakeModePolymerBondRenderer by several classes #5497

DmitriiP-EPAM opened this issue Sep 11, 2024 · 1 comment · Fixed by #5498 · May be fixed by #6033
Assignees
@DmitriiP-EPAM
Labels
refactor Code refactoring, without changing the functionality technical debt
Milestone
Ketcher 2.27.0-rc.1

Comments

@DmitriiP-EPAM
Copy link
Collaborator

DmitriiP-EPAM commented Sep 11, 2024 •
edited
Loading

Create:

  • SnakeModeBackboneBondRenderer (black “snake” line)
  • SnakeModeSideChainBondRenderer (blue “snake” line)
  • SnakeModeRNABaseAndSugarBondRenderer (black straight line)

Next step after #5128
@DmitriiP-EPAM DmitriiP-EPAM self-assigned this Sep 11, 2024
@DmitriiP-EPAM DmitriiP-EPAM moved this from To do to In progress in Technical Debt Sep 11, 2024
DmitriiP-EPAM added a commit that referenced this issue Sep 11, 2024
@DmitriiP-EPAM
#5497 – Refactor (Connection.ts): Specify the types
dfdea0a
DmitriiP-EPAM added a commit that referenced this issue Sep 11, 2024
@DmitriiP-EPAM
#5497 – Refactor (Connection.ts): Rename xOffset
33540e3
@DmitriiP-EPAM DmitriiP-EPAM linked a pull request Sep 11, 2024 that will close this issue
#5497 – Refactor: Specify the types of classes for SnakeModePolymerBondRenderer #5498
Merged
13 tasks
DmitriiP-EPAM added a commit that referenced this issue Sep 12, 2024
@DmitriiP-EPAM
#5497 – Refactor (SnakeModePolymerBondRenderer.ts): Specify the types
b7a4ae8
DmitriiP-EPAM added a commit that referenced this issue Sep 12, 2024
@DmitriiP-EPAM
#5497 – Refactor (Connection.ts): Specify the types (amend)
f7ee479
DmitriiP-EPAM added a commit that referenced this issue Sep 12, 2024
@DmitriiP-EPAM
Revert "#5497 – Refactor (Connection.ts): Rename xOffset"
aaf6402 
This reverts commit 33540e3.
DmitriiP-EPAM added a commit that referenced this issue Sep 12, 2024
@DmitriiP-EPAM
#5497 – Refactor (SnakeModePolymerBondRenderer.ts): Specify the types…
c3d208e 
…, refactor the calculation of `endOfPathPart`
DmitriiP-EPAM added a commit that referenced this issue Sep 12, 2024
@DmitriiP-EPAM
#5497 – Refactor (CanvasMatrix.ts): Specify the types
4f9eeb8
DmitriiP-EPAM added a commit that referenced this issue Sep 12, 2024
@DmitriiP-EPAM
#5497 – Refactor (CanvasMatrix.ts): Use new Connection(6)
ca58260
DmitriiP-EPAM added a commit that referenced this issue Sep 13, 2024
@DmitriiP-EPAM
#5497 – Refactor (Connection.ts): Rename xOffset
49fb5f1
DmitriiP-EPAM added a commit that referenced this issue Sep 13, 2024
@DmitriiP-EPAM
#5497 – Refactor (SnakeModePolymerBondRenderer.ts): Change FIXME text
bfec6da
DmitriiP-EPAM added a commit that referenced this issue Sep 13, 2024
@DmitriiP-EPAM
#5497 – Refactor (Connection.ts): Rename `ConnectionDirectionInDegree…
fb6b2eb 
…s`, `ConnectionDirectionOfLastCell`
@DmitriiP-EPAM DmitriiP-EPAM moved this from In progress to In review in Technical Debt Sep 19, 2024
rrodionov91 pushed a commit that referenced this issue Oct 10, 2024
@DmitriiP-EPAM
#5497 – Refactor: Specify the types of classes for `SnakeModePolymerB…
94e546c 
…ondRenderer` (#5498)

* #5497 – Refactor (Connection.ts): Specify the types

* #5497 – Refactor (Connection.ts): Rename `xOffset`

* #5497 – Refactor (SnakeModePolymerBondRenderer.ts): Specify the types

* #5497 – Refactor (Connection.ts): Specify the types (amend)

* Revert "#5497 – Refactor (Connection.ts): Rename `xOffset`"

This reverts commit 33540e3.

* #5497 – Refactor (SnakeModePolymerBondRenderer.ts): Specify the types, refactor the calculation of `endOfPathPart`

* #5497 – Refactor (CanvasMatrix.ts): Specify the types

* #5497 – Refactor (CanvasMatrix.ts): Use `new Connection(6)`

* #5497 – Refactor (Connection.ts): Rename `xOffset`

* #5497 – Refactor (SnakeModePolymerBondRenderer.ts): Change `FIXME` text

* #5497 – Refactor (Connection.ts): Rename `ConnectionDirectionInDegrees`, `ConnectionDirectionOfLastCell`
@github-project-automation github-project-automation bot moved this from In review to Done in Technical Debt Oct 10, 2024
rrodionov91 pushed a commit that referenced this issue Oct 13, 2024
@DmitriiP-EPAM @rrodionov91
#5497 – Refactor: Specify the types of classes for `SnakeModePolymerB…
d9d1f37 
…ondRenderer` (#5498)

* #5497 – Refactor (Connection.ts): Specify the types

* #5497 – Refactor (Connection.ts): Rename `xOffset`

* #5497 – Refactor (SnakeModePolymerBondRenderer.ts): Specify the types

* #5497 – Refactor (Connection.ts): Specify the types (amend)

* Revert "#5497 – Refactor (Connection.ts): Rename `xOffset`"

This reverts commit 33540e3.

* #5497 – Refactor (SnakeModePolymerBondRenderer.ts): Specify the types, refactor the calculation of `endOfPathPart`

* #5497 – Refactor (CanvasMatrix.ts): Specify the types

* #5497 – Refactor (CanvasMatrix.ts): Use `new Connection(6)`

* #5497 – Refactor (Connection.ts): Rename `xOffset`

* #5497 – Refactor (SnakeModePolymerBondRenderer.ts): Change `FIXME` text

* #5497 – Refactor (Connection.ts): Rename `ConnectionDirectionInDegrees`, `ConnectionDirectionOfLastCell`
Guch1g0v pushed a commit that referenced this issue Oct 17, 2024
@DmitriiP-EPAM @Guch1g0v
#5497 – Refactor: Specify the types of classes for `SnakeModePolymerB…
07e9f52 
…ondRenderer` (#5498)

* #5497 – Refactor (Connection.ts): Specify the types

* #5497 – Refactor (Connection.ts): Rename `xOffset`

* #5497 – Refactor (SnakeModePolymerBondRenderer.ts): Specify the types

* #5497 – Refactor (Connection.ts): Specify the types (amend)

* Revert "#5497 – Refactor (Connection.ts): Rename `xOffset`"

This reverts commit 33540e3.

* #5497 – Refactor (SnakeModePolymerBondRenderer.ts): Specify the types, refactor the calculation of `endOfPathPart`

* #5497 – Refactor (CanvasMatrix.ts): Specify the types

* #5497 – Refactor (CanvasMatrix.ts): Use `new Connection(6)`

* #5497 – Refactor (Connection.ts): Rename `xOffset`

* #5497 – Refactor (SnakeModePolymerBondRenderer.ts): Change `FIXME` text

* #5497 – Refactor (Connection.ts): Rename `ConnectionDirectionInDegrees`, `ConnectionDirectionOfLastCell`
@AlexeyGirin
Copy link
Collaborator

No testing required

DmitriiP-EPAM added a commit that referenced this issue Dec 3, 2024
@DmitriiP-EPAM
#5497 – Refactor (SnakeModePolymerBondRenderer): Refactor `generateBe…
94e5c71 
…nd(4)`
DmitriiP-EPAM added a commit that referenced this issue Dec 3, 2024
@DmitriiP-EPAM
#5497 – Refactor (SnakeModeHydrogenBondRenderer): Refactor `generateB…
d6e6dd7 
…end(4)`
DmitriiP-EPAM added a commit that referenced this issue Dec 3, 2024
@DmitriiP-EPAM
#5497 – Refactor (BaseRenderer.ts): Create selectionElement
1dcc4b1
DmitriiP-EPAM added a commit that referenced this issue Dec 3, 2024
@DmitriiP-EPAM
#5497 – Refactor (BaseRenderer.ts): Cancel the creation of `selection…
2cda4d4 
…Element`
DmitriiP-EPAM added a commit that referenced this issue Dec 3, 2024
@DmitriiP-EPAM
#5497 – Refactor (types.ts): Rename Datum
6f64110
DmitriiP-EPAM added a commit that referenced this issue Dec 3, 2024
@DmitriiP-EPAM
#5497 – Refactor (SnakeModePolymerBondRenderer): Create and use `Side…
db02fea 
…ChainConnectionBondRenderer`
DmitriiP-EPAM added a commit that referenced this issue Dec 4, 2024
@DmitriiP-EPAM
#5497 – Refactor (PolymerBond): Correct by the code style
557aab8
DmitriiP-EPAM added a commit that referenced this issue Dec 4, 2024
@DmitriiP-EPAM
#5497 – Refactor (SnakeModeHydrogenBondRenderer): Specify the types
6c4481c
DmitriiP-EPAM added a commit that referenced this issue Dec 5, 2024
@DmitriiP-EPAM
#5497 – Refactor / Bugfix (SnakeModePolymerBondRenderer): Recover `si…
0dd84e6 
…deConnectionBondTurnPoint` update
DmitriiP-EPAM added a commit that referenced this issue Dec 6, 2024
@DmitriiP-EPAM
#5497 – Refactor (SideChainConnectionBondRenderer): Create `calculate…
37f0128 
…EndOfPathPart(1)`
DmitriiP-EPAM added a commit that referenced this issue Dec 6, 2024
@DmitriiP-EPAM
#5497 – Refactor (SideChainConnectionBondRenderer): Create the interf…
1062c3e 
…aces for `drawPartOfSideConnection(1)`
DmitriiP-EPAM added a commit that referenced this issue Dec 6, 2024
@DmitriiP-EPAM
#5497 – Refactor (SideChainConnectionBondRenderer): Specify the types
a2cc652
DmitriiP-EPAM added a commit that referenced this issue Dec 6, 2024
@DmitriiP-EPAM
#5497 – Refactor (SnakeModeSideChainBondRenderer): Rename the class
79de1bc
DmitriiP-EPAM added a commit that referenced this issue Dec 6, 2024
@DmitriiP-EPAM
#5497 – Refactor (SnakeModePolymerBondRenderer): Specify the type
bba5bcd
DmitriiP-EPAM added a commit that referenced this issue Dec 6, 2024
@DmitriiP-EPAM
#5497 – Refactor (SnakeModeSideChainBondRenderer): Rename the class (…
2d6a68e 
…part 2)
DmitriiP-EPAM added a commit that referenced this issue Dec 6, 2024
@DmitriiP-EPAM
#5497 – Refactor (SnakeModeSideChainBondRenderer): Create `appendPath…
cfe6f84 
…ToElement(1)`
DmitriiP-EPAM added a commit that referenced this issue Dec 6, 2024
@DmitriiP-EPAM
#5497 – Refactor (SnakeModeSideChainBondRenderer): Delete the useless…
b9c20c0 
… `.attr('stroke-dasharray', '0')`
DmitriiP-EPAM added a commit that referenced this issue Dec 6, 2024
@DmitriiP-EPAM
#5497 – Refactor (SnakeModePolymerBondRenderer): Create the constant …
75f294a 
…for the colors
DmitriiP-EPAM added a commit that referenced this issue Dec 6, 2024
@DmitriiP-EPAM
#5497 – Refactor (SnakeModeSideChainBondRenderer): Rename `calculateS…
7130f51 
…ideConnectionBondTurnPoint(1)`
@DmitriiP-EPAM DmitriiP-EPAM linked a pull request Dec 9, 2024 that will close this issue
#5497 – Refactor (SnakeModePolymerBondRenderer): Create SnakeModeSideChainBondRenderer #6033
Open
9 tasks
@DmitriiP-EPAM DmitriiP-EPAM added technical debt refactor Code refactoring, without changing the functionality labels Dec 9, 2024
@DmitriiP-EPAM DmitriiP-EPAM reopened this Dec 9, 2024
@github-project-automation github-project-automation bot moved this from Done to In progress in Technical Debt Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DmitriiP-EPAM DmitriiP-EPAM

Labels
refactor Code refactoring, without changing the functionality technical debt
Projects
Technical Debt
Status: In progress
Milestone
Ketcher 2.27.0-rc.1
3 participants
@rrodionov91 @AlexeyGirin @DmitriiP-EPAM