Gui improvements 28 06 2024 #3762
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aging for clusters tab
kamyshova
requested changes
Nov 8, 2024
Comment on lines
325
to
327
| if (!clusterMenu().context().$$(node()).stream() | ||
| .filter(not(master())) | ||
| .collect(toList()).isEmpty()) { |
There was a problem hiding this comment.
Could we simplify this to clusterMenu().context().$$(node()).stream().anyMatch(not(master()))?
| @@ -300,4 +320,19 @@ private static Stream<String> prepareExpectedLogMessages(final String pipelineNa | |||
| private static LogAO onRunPage() { | |||
| return new LogAO(); | |||
| } | |||
|
|
|||
| private void checkNodes() { | |||
There was a problem hiding this comment.
Maybe it will be better to use just one forEach() where we check the condition for each node() instead of the same two stream
| @@ -55,7 +55,8 @@ protected StorageRulesTabAO open() { | |||
|
|
|||
| public StorageRulesTabAO deleteStorageRule(String fileMaskString) { | |||
| $(byText(fileMaskString)).closest("tr").findAll(tagName("td")).get(3).find(tagName("a")).shouldHave(text("Delete")).click(); | |||
| $(className("ant-confirm-title")).shouldHave(text("Do you want to delete rule \"" + fileMaskString + "\"?")); | |||
| $$(className("ant-confirm-title")).filter(text("Do you want to delete rule")).first() | |||
There was a problem hiding this comment.
Could we add line breaks?
Comment on lines
234
to
248
| public ToolSettings clickCustomParameter() { | ||
| return clickAddParameter("String parameter"); | ||
| } | ||
|
|
||
| private ToolSettings clickAddParameter(String parameterType) { | ||
| $(byId("add-parameter-dropdown-button")).shouldBe(visible).hover(); | ||
| $(byText(parameterType)).shouldBe(visible).click(); | ||
| return this; | ||
| } | ||
|
|
||
| public ToolSettings setName(String name, int parameterIndex) { | ||
| SelenideElement nameField = $(byId(String.format("parameters.params.param_%d.name", parameterIndex))); | ||
| nameField.click(); | ||
| setValue(nameField, name); | ||
| return this; |
There was a problem hiding this comment.
Could we reuse parameter logic from RunParameterAO?
| @@ -15,6 +15,7 @@ | |||
| */ | |||
| package com.epam.pipeline.autotests.mixins; | |||
|
|
|||
| import static com.codeborne.selenide.Condition.exist; | |||
| @@ -127,6 +127,7 @@ public class C { | |||
| DEFAULT_CLUSTER_AWS_EBS_TYPE = conf.getProperty("e2e.ui.cluster.aws.ebs.type"); | |||
| TEST_RUN_TAG = conf.getProperty("e2e.ui.test.run.tag"); | |||
| DEFAULT_CLOUD_REGION = conf.getProperty("e2e.ui.default.cloud.region"); | |||
| SSH_CLOUD_REGION = conf.getProperty("e2e.ssh.cloud.region"); | |||
There was a problem hiding this comment.
I believe we should add this config to the default.conf too
Signed-off-by: Yulia Kamyshova <[email protected]>
# Conflicts: # e2e/gui/src/test/java/com/epam/pipeline/autotests/LaunchParametersTest.java
kamyshova
approved these changes
Dec 24, 2024
| return new ToolParameterAO(this, parameterIndex); | ||
| } | ||
|
|
||
| public ToolParameterAO getParameterByIndex(int parameterIndex) { |
Signed-off-by: Yulia Kamyshova <[email protected]>
Signed-off-by: Yulia Kamyshova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides following updates:
umont#2736 test was changed