Issue 3751 Allow to grant permissions to group #3752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SilinPavel
requested changes
Oct 23, 2024
| @PostFilter(USER_READ_FILTER) | ||
| @AclMaskList | ||
| public List<Role> loadRolesWithUsers() { | ||
| return new ArrayList<>(roleManager.loadAllRoles(true)); |
There was a problem hiding this comment.
instead of recreating list once again (in dao class we already returning a list) let's just change signature of the corresponding methods
| @PostFilter(USER_READ_FILTER) | ||
| @AclMaskList | ||
| public List<Role> loadRoles() { | ||
| return new ArrayList<>(roleManager.loadAllRoles(false)); |
| @@ -407,7 +403,7 @@ private void checkEntityExistsAndCanBeModified(final Long entityId, final AclCla | |||
| private Object loadEntity(final Long entityId, final AclClass entityClass) { | |||
| Object entity; | |||
| if (entityClass.equals(AclClass.ROLE)) { | |||
There was a problem hiding this comment.
since now Role is a SecuredEntity we can support same way to load it as for all other types of SecuredEntity
| public ExtendedRole loadRoleWithUsers(Long roleId) { | ||
| loadRole(roleId); | ||
| public ExtendedRole loadRoleWithUsers(final Long roleId) { | ||
| load(roleId); |
There was a problem hiding this comment.
seems to me as an necessary load call, what you think?
SilinPavel
reviewed
Oct 24, 2024
| @@ -115,6 +116,7 @@ | |||
| r.user_default as role_user_default, | |||
| r.default_storage_id as role_default_storage_id, | |||
| r.default_profile_id as role_default_profile_id, | |||
| r.owner as role_owner | |||
…when working with ACL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to grant permissions to group #3751