Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert openapi request to dial format #456

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

AliakseiBuhakou
Copy link

New feature: conversion of the openapi request to dial old format to support both request types

@ai-dial-actions
Copy link
Contributor

ai-dial-actions commented Aug 23, 2024

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Convert openapi request to dial format". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - fix
 - hotfix
 - feat
 - feature
 - chore

@astsiapanay
Copy link
Collaborator

astsiapanay commented Aug 23, 2024

Hi @AliakseiBuhakou,

Could you please link the PR to an issue to be reported in DIAL Core project?

If the issue doesn't exist please create it.



@UtilityClass
public class RequestUtil {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please a javadoc explaining the purpose of the class

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I will

@astsiapanay
Copy link
Collaborator

@sdryapko
Should the feature be planned and included into the current milestone?
I don't remember we discussed that on meetings.

@AliakseiBuhakou
Copy link
Author

Hi @AliakseiBuhakou,

Could you please link the PR to an issue to be reported in DIAL Core project?

If the issue doesn't exist please create it.

Unfortunately, I don't have access to it.

@astsiapanay
Copy link
Collaborator

Hi @AliakseiBuhakou,
Could you please link the PR to an issue to be reported in DIAL Core project?
If the issue doesn't exist please create it.

Unfortunately, I don't have access to it.

@sdryapko
Please give access @AliakseiBuhakou to report an issue to DIAL Core project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants