fix: HTTPRoute status only shows one parent when targeting multiple Gateways from different GatewayClasses #4587
+359
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaohuabing
force-pushed
the
fix-route-status
branch
from
1944b8f
to
47a096f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4587 +/- ##
==========================================
+ Coverage 65.43% 65.49% +0.06%
==========================================
Files 211 211
Lines 31904 31942 +38
==========================================
+ Hits 20875 20922 +47
+ Misses 9784 9777 -7
+ Partials 1245 1243 -2 ☔ View full report in Codecov by Sentry. |
zhaohuabing
force-pushed
the
fix-route-status
branch
2 times, most recently
from
0991e3f
to
c1a0b50
Compare
Signed-off-by: Huabing Zhao <[email protected]>
zhaohuabing
force-pushed
the
fix-route-status
branch
from
c1a0b50
to
1b2470e
Compare
zhaohuabing
changed the title
arkodg
reviewed
Oct 31, 2024
arkodg
reviewed
Oct 31, 2024
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4264
Release Notes: Yes