Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: enable test for dual stack cluster #4574

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Conversation

zirain
Copy link
Contributor

@zirain zirain commented Oct 30, 2024

xref: #4572

seperate from #4550

@zirain zirain requested a review from a team as a code owner October 30, 2024 09:41
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.48%. Comparing base (b0c6f8c) to head (fa32d00).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4574      +/-   ##
==========================================
+ Coverage   65.47%   65.48%   +0.01%     
==========================================
  Files         211      211              
  Lines       31858    31858              
==========================================
+ Hits        20859    20863       +4     
+ Misses       9755     9752       -3     
+ Partials     1244     1243       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from a team October 31, 2024 01:05
@arkodg arkodg merged commit bb3bbdb into envoyproxy:main Oct 31, 2024
24 checks passed
@zhaohuabing
Copy link
Member

@zirain should this be cherry-pick into v1.2.0?

@zirain zirain deleted the test-on-dual branch October 31, 2024 10:31
@arkodg
Copy link
Contributor

arkodg commented Oct 31, 2024

@zirain should this be cherry-pick into v1.2.0?

@zhaohuabing yes, added the cherry-pick

@zhaohuabing zhaohuabing added this to the v1.2.0 milestone Nov 1, 2024
zhaohuabing pushed a commit to zhaohuabing/gateway that referenced this pull request Nov 1, 2024
* ci: enable dual stack test

Signed-off-by: zirain <[email protected]>

* more comment

Signed-off-by: zirain <[email protected]>

* remove 1.31.0 ipv4 test suite

Signed-off-by: zirain <[email protected]>

---------

Signed-off-by: zirain <[email protected]>
(cherry picked from commit bb3bbdb)
Signed-off-by: Huabing Zhao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants