Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix incorrect namespace mention #4563

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

klmz
Copy link

@klmz klmz commented Oct 29, 2024

The docs mention the wrong namespace for annotations. The namespace is set here I think: https://github.com/guydc/gateway/blob/e54b00f4e227e0e7d65bc6dbecf5b6d1f991dd7e/internal/gatewayapi/route.go#L35

It might be that i misunderstood the documentation and i'm mixing things up. If so, ill be happy to write a separate section with this example.

What type of PR is this?
Small correction to the docs.

What this PR does / why we need it:
It adds the correct namespace, and a small example of how to use it.

Which issue(s) this PR fixes:

Release Notes: No

The namespace is incorrect

Signed-off-by: Joost Naaijen <[email protected]>
@klmz klmz requested a review from a team as a code owner October 29, 2024 16:22
Signed-off-by: Joost Naaijen <[email protected]>
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@74e5750). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4563   +/-   ##
=======================================
  Coverage        ?   65.49%           
=======================================
  Files           ?      211           
  Lines           ?    31858           
  Branches        ?        0           
=======================================
  Hits            ?    20865           
  Misses          ?     9751           
  Partials        ?     1242           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arkodg arkodg requested a review from guydc October 29, 2024 17:57
Signed-off-by: Joost Naaijen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant