Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/v1.1] fix: validate proto messages before converting them to anypb.Any (#4499) #4558

Open
wants to merge 1 commit into
base: release/v1.1
Choose a base branch
from

Conversation

zhaohuabing
Copy link
Member

Fix #4504

(cherry picked from commit 05817fc)

@zhaohuabing zhaohuabing requested a review from a team as a code owner October 29, 2024 02:22
…oyproxy#4499)

* validate proto message before converting to any

Signed-off-by: Huabing Zhao <[email protected]>
(cherry picked from commit 05817fc)
Signed-off-by: Huabing Zhao <[email protected]>
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 52.45902% with 58 lines in your changes missing coverage. Please review.

Project coverage is 66.94%. Comparing base (7391c1c) to head (c90b3f5).

Files with missing lines Patch % Lines
internal/xds/translator/listener.go 55.00% 12 Missing and 6 partials ⚠️
internal/xds/translator/accesslog.go 30.43% 12 Missing and 4 partials ⚠️
internal/xds/translator/translator.go 15.38% 7 Missing and 4 partials ⚠️
internal/utils/protocov/protocov.go 71.42% 3 Missing and 1 partial ⚠️
internal/xds/translator/authorization.go 33.33% 0 Missing and 4 partials ⚠️
internal/xds/translator/basicauth.go 0.00% 0 Missing and 2 partials ⚠️
internal/xds/translator/wasm.go 0.00% 0 Missing and 2 partials ⚠️
internal/xds/translator/healthcheck.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release/v1.1    #4558      +/-   ##
================================================
- Coverage         67.36%   66.94%   -0.42%     
================================================
  Files               183      183              
  Lines             22519    28064    +5545     
================================================
+ Hits              15169    18788    +3619     
- Misses             6261     8184    +1923     
- Partials           1089     1092       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested a review from guydc October 30, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants