Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use grafana alloy instead of fluent-bit #4525

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zirain
Copy link
Contributor

@zirain zirain commented Oct 25, 2024

  • this will make configuration simpler and test run faster
  • easier to support IPv6 and Dual

@zirain zirain requested a review from a team as a code owner October 25, 2024 05:56
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.50%. Comparing base (6f5ae8e) to head (7b6ed87).
Report is 27 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4525      +/-   ##
==========================================
- Coverage   65.72%   65.50%   -0.22%     
==========================================
  Files         211      211              
  Lines       31669    31858     +189     
==========================================
+ Hits        20813    20870      +57     
- Misses       9656     9746      +90     
- Partials     1200     1242      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaohuabing
Copy link
Member

Hi @zirain curios why grafana alloy is faster than fluent-bit?

@zhaohuabing
Copy link
Member

zhaohuabing commented Oct 28, 2024

There are two copies of logs in the loki?

@zirain
Copy link
Contributor Author

zirain commented Oct 28, 2024

Hi @zirain curios why grafana alloy is faster than fluent-bit?

it's faster on my local cluster.

@arkodg
Copy link
Contributor

arkodg commented Oct 28, 2024

I would prefer to keep the more popular one (for users who are using EG or likely to use it) rather than the faster one

@zirain zirain closed this Oct 29, 2024
@zirain zirain deleted the alloy branch October 29, 2024 00:31
@zirain zirain restored the alloy branch October 29, 2024 00:31
@zirain zirain reopened this Oct 29, 2024
@zirain
Copy link
Contributor Author

zirain commented Oct 29, 2024

I would prefer to keep the more popular one (for users who are using EG or likely to use it) rather than the faster one

I want to bring this back cause I cannot figure out how to make fluent-bit support IPv6 and Dual.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/IPv6 IPv6 related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants