Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update absl to 20240722.1 #38170

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

asedeno
Copy link
Contributor

@asedeno asedeno commented Jan 23, 2025

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Jan 23, 2025
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @RyanTheOptimist

🐱

Caused by: #38170 was opened by asedeno.

see: more, trace.

@asedeno
Copy link
Contributor Author

asedeno commented Jan 23, 2025

/retest

@asedeno
Copy link
Contributor Author

asedeno commented Jan 23, 2025

Looks like this has some real issue to track down. Switching to a draft for now.

@asedeno asedeno marked this pull request as draft January 23, 2025 23:23
@asedeno
Copy link
Contributor Author

asedeno commented Jan 24, 2025

From logs for //test/extensions/network/dns_resolver/getaddrinfo:getaddrinfo_test

[ RUN      ] GetAddrInfoDnsImplTest.LocalhostResolve
test/extensions/network/dns_resolver/getaddrinfo/getaddrinfo_test.cc:134: Failure
Value of: traces
Expected: has 4 elements where
element #0 has trace 1-byte object <00>,
element #1 has trace 1-byte object <01>,
element #2 has trace 1-byte object <02>,
element #3 has trace 1-byte object <08>
  Actual: { "1=448270020820", "0=448270024220", "2=448270386340", "8=448270437260" }, whose element #0 doesn't match

This trace is odd.

1=448270020820Starting
0=448270024220NotStarted after Starting, with later timestamp
2=448270386340Success
8=448270437260Cancelled

@asedeno
Copy link
Contributor Author

asedeno commented Jan 24, 2025

This appears to be a race condition. The not NotStarted trace is added to the query after putting the query in the queue for another thread to process. There's no guarantee that the resolver thread hasn't grabbed it before adding the NotStarted trace.

x-ref: #36312
CC: @fredyw, @alyssawilk

@asedeno
Copy link
Contributor Author

asedeno commented Jan 24, 2025

Opened #38186 for the race condition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps Approval required for changes to Envoy's external dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Newer release available com_google_absl: 20240722.1 (current: 20240722.0)
2 participants