xds: refactor ADS related data to xDS-Manager part 1 #38145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adi Suissa-Peleg <[email protected]>
|
/assign @nezdolik |
nezdolik
reviewed
Jan 24, 2025
| * @param cm - a pointer to a valid cluster manager. | ||
| * @return Ok if the initialization was successful, or an error otherwise. | ||
| */ | ||
| virtual absl::Status initialize(Upstream::ClusterManager* cm) PURE; |
There was a problem hiding this comment.
should the param be a reference type instead? E.g. this way the api would imply you can only use it with a valid cm instance
|
|
||
| // Config::ConfigSourceProvider | ||
| absl::Status initialize(Upstream::ClusterManager* cm) override; | ||
| void shutdown() override {} |
There was a problem hiding this comment.
will this be implemented later?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: xds: refactor ADS related data to xDS-Manager part 1
Additional Description:
As part of the work on #24773 the xDS-related functionality needs to be moved from the cluster-manager to the xDS-manager.
This is the first refactor: moving the xDS-manager initialization to the end of the cluster-manager's c'tor.
Risk Level: low
Testing: Updated tests.
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A